Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

鈽傦笍Slow Unit Test 馃寕 1.30/1.31 #123685

Open
3 of 22 tasks
pacoxu opened this issue Mar 5, 2024 · 11 comments
Open
3 of 22 tasks

鈽傦笍Slow Unit Test 馃寕 1.30/1.31 #123685

pacoxu opened this issue Mar 5, 2024 · 11 comments
Assignees
Labels
area/test help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@pacoxu
Copy link
Member

pacoxu commented Mar 5, 2024

https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/ci-kubernetes-unit-1-27 takes ~35min
https://prow.k8s.io/job-history/gs/kubernetes-jenkins/logs/ci-kubernetes-unit taks ~40min

There are some adding UT. New below is comparing with v1.27. (The test or package may be old, but it takes more than 1m in UT in master, and not take more than 1m in v1.27.)

/sig node api-machinery cli
for new ones.

#98486 we did a similar check in 2021 before.


#123850 (comment) We have a 3 minute timeout for a package.

# TODO: This timeout should really be lower, this is a *long* time to test one
# package, however pkg/api/testing in particular will fail with a lower timeout
# currently. We should attempt to lower this over time.
KUBE_TIMEOUT=${KUBE_TIMEOUT:--timeout=180s}
KUBE_COVER=${KUBE_COVER:-n} # set to 'y' to enable coverage collection

@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 5, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Mar 5, 2024

/area test
/kind cleanup
/help wanted

@k8s-ci-robot k8s-ci-robot added area/test kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Mar 5, 2024
@pacoxu
Copy link
Member Author

pacoxu commented Mar 5, 2024

/sig node api-machinery cli

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/cli Categorizes an issue or PR as relevant to SIG CLI. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2024
@HirazawaUi
Copy link
Contributor

/help

@k8s-ci-robot
Copy link
Contributor

@HirazawaUi:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Mar 5, 2024
@HirazawaUi
Copy link
Contributor

k8s.io/kubernetes/pkg/kubelet/cm/dra #123720

time required before modification:

go test ./... -cover -count=1
ok  	k8s.io/kubernetes/pkg/kubelet/cm/dra	94.097s	coverage: 83.8% of statements

time required after modification

go test ./... -cover -count=1
ok  	k8s.io/kubernetes/pkg/kubelet/cm/dra	1.356s	coverage: 83.8% of statements

@p0lyn0mial
Copy link
Contributor

I will try to decrease the running time of the apiserver/pkg/storage/cacher pkg.

@leilajal
Copy link
Contributor

/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Mar 26, 2024
@SergeyKanzhelev
Copy link
Member

/assign @bart0sh

for k8s.io/kubernetes/pkg/kubelet/cm: dra

@HirazawaUi
Copy link
Contributor

/assign @bart0sh

for k8s.io/kubernetes/pkg/kubelet/cm: dra

Fixed in #123720

@brianpursley
Copy link
Member

This one has been fixed by #124494

[ ] New k8s.io/kubectl/pkg/cmd: apply

@pacoxu pacoxu changed the title 鈽傦笍Slow Unit Test 馃寕 鈽傦笍Slow Unit Test 馃寕 1.30/1.31 Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
Status: Needs Triage
SIG Node CI/Test Board
Issues - In progress
Development

No branches or pull requests

8 participants