Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRA: scheduler: refactor foreachPodResourceClaim #123697

Open
pohly opened this issue Mar 5, 2024 · 1 comment
Open

DRA: scheduler: refactor foreachPodResourceClaim #123697

pohly opened this issue Mar 5, 2024 · 1 comment
Assignees
@pohly
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@pohly
Copy link
Contributor

pohly commented Mar 5, 2024

What would you like to be added?

foreachPodResourceClaim in pkg/scheduler/framework/plugins/dynamicresources/dynamicresources.go could be changed so that it gathers all information about a claim, including structured claim and class parameters. Instead of two slices of the same size (claims and informationsForClaim) we should only have one.

Why is this needed?

  • isSchedulableAfterClaimChange can then trigger only for claims with structured parameters and ignore the others
  • Some checks currently only done in PreFilter can already be done in PreEnqueue.

Together this reduces the overall work.

/sig node
/triage accepted
/priority important-longterm
/lifecycle frozen
/assign
@pohly pohly added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. labels Mar 5, 2024
@pohly
Copy link
Contributor Author

pohly commented Mar 14, 2024

Unit test coverage for isSchedulableAfterClaimParametersChange and isSchedulableAfterClassParametersChange needs to be improved, which is related to this.

pohly added a commit to pohly/kubernetes that referenced this issue Mar 14, 2024
@pohly
dra scheduler: unit tests
59f7e5f 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
pohly added a commit to pohly/kubernetes that referenced this issue Mar 14, 2024
@pohly
dra scheduler: unit tests
2b07df5 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
pohly added a commit to pohly/kubernetes that referenced this issue Mar 14, 2024
@pohly
dra scheduler: unit tests
4179c63 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
pohly added a commit to pohly/kubernetes that referenced this issue Mar 15, 2024
@pohly
dra scheduler: unit tests
ec86c09 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
pohly added a commit to pohly/kubernetes that referenced this issue Mar 19, 2024
@pohly
dra scheduler: unit tests
8f29300 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
pohly added a commit to pohly/kubernetes that referenced this issue Mar 20, 2024
@pohly
dra scheduler: unit tests
79ed4eb 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
pohly added a commit to pohly/kubernetes that referenced this issue Mar 22, 2024
@pohly
dra scheduler: unit tests
458e227 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
jingczhang pushed a commit to nokia/kubernetes that referenced this issue May 7, 2024
@pohly @jingczhang
dra scheduler: unit tests
b95da88 
Coverage was checked with a cover profile. The biggest remaining gap is for
isSchedulableAfterClaimParametersChange and
isSchedulableAfterClassParametersChange which will get handled when refactoring
the
foreachPodResourceClaim (kubernetes#123697).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pohly pohly

Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/node Categorizes an issue or PR as relevant to SIG Node. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Node: Dynamic Resource Allocation
Status: 🔖 Ready
Milestone
No milestone
Development

No branches or pull requests
2 participants
@pohly @k8s-ci-robot