Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test for change in syncOrphanPod for managedBy jobs #123723

Merged
merged 1 commit into from Mar 8, 2024
Merged

Integration test for change in syncOrphanPod for managedBy jobs #123723

merged 1 commit into from Mar 8, 2024

Conversation

mimowo
Copy link
Contributor

@mimowo mimowo commented Mar 5, 2024 •
edited

/sig apps

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

To demonstrate the change in syncOrphanPod, in #123273, works as expected and prevent regressions.

Which issue(s) this PR fixes:

Part of enhancement tracking issue: kubernetes/enhancements#4368

Special notes for your reviewer:

I add a sleep of 100ms to make sure the test fails if not for the skip. I tested that even without the sleep it fails 90% of time.

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

https://github.com/kubernetes/enhancements/tree/master/keps/sig-apps/4368-support-managed-by-label-for-batch-jobs

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. sig/apps Categorizes an issue or PR as relevant to SIG Apps. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/code-generation area/test kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 5, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Mar 5, 2024

/hold
For #123273 to land and rebase.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 5, 2024
@tenzen-y
Copy link
Member

tenzen-y commented Mar 5, 2024

/cc

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 5, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Mar 5, 2024 •
edited

Cleanup of labels after rebase, this is just a test:
/remove-area code-generation
/remove-kind api-change
/remove-sig api-machinery

@k8s-ci-robot k8s-ci-robot removed area/code-generation kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Mar 5, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Mar 5, 2024

/cc @atiratree

@mimowo mimowo force-pushed the job-managed-by-impl-test branch 2 times, most recently from 401a4bd to 5db9e70 Compare March 6, 2024 12:37
@mimowo mimowo changed the title WIP: integration test for change in syncOrphanPod for managedBy jobs Integration test for change in syncOrphanPod for managedBy jobs Mar 6, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 6, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Mar 6, 2024

/hold cancel
The PR is now rebased and cleaned up. Ready for review :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 6, 2024
@mimowo
Copy link
Contributor Author

mimowo commented Mar 6, 2024

/retest

atiratree
atiratree reviewed Mar 7, 2024
View reviewed changes
Copy link
Member

@atiratree atiratree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

two remarks, otherwise lgtm

test/integration/job/job_test.go Outdated Show resolved Hide resolved
test/integration/job/job_test.go Outdated Show resolved Hide resolved
@atiratree
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 2b3912c9017af6de125aa650a44dd60ad4eb753b

@mimowo
Copy link
Contributor Author

mimowo commented Mar 7, 2024

/assign @soltysh

@mimowo
Copy link
Contributor Author

mimowo commented Mar 7, 2024

/retest

soltysh
soltysh approved these changes Mar 8, 2024
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2024
@soltysh
Copy link
Contributor

soltysh commented Mar 8, 2024

/triage accepted
/priority important-longterm
/milestone v1.30

@k8s-ci-robot k8s-ci-robot added this to the v1.30 milestone Mar 8, 2024
@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Mar 8, 2024
@alculquicondor
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: alculquicondor, mimowo, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 5639f8f into kubernetes:master Mar 8, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atiratree atiratree atiratree left review comments

@soltysh soltysh soltysh approved these changes

@aojea aojea Awaiting requested review from aojea

@deads2k deads2k Awaiting requested review from deads2k

@tenzen-y tenzen-y Awaiting requested review from tenzen-y

Assignees

@soltysh soltysh

@atiratree atiratree

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. release-note-none Denotes a PR that doesn't merit a release note. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
SIG Apps
Archived in project
Milestone
v1.30
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@mimowo @tenzen-y @atiratree @k8s-ci-robot @soltysh @alculquicondor