Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRA API: don't allow changing object meta during status update #123727

Closed
pohly opened this issue Mar 5, 2024 · 3 comments · Fixed by #123730
Closed

DRA API: don't allow changing object meta during status update #123727

pohly opened this issue Mar 5, 2024 · 3 comments · Fixed by #123730
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.

Comments

@pohly
Copy link
Contributor

pohly commented Mar 5, 2024

What happened?

The strategy.go's PrepareForStatusUpdate was copied from some other, broken types. A call to ResetObjectMetaForStatus is missing and therefore, for example, finalizers can be changed during a status update. That is not supposed to be possible.

What did you expect to happen?

Object meta changes need to be removed during status updates.

How can we reproduce it (as minimally and precisely as possible)?

n/a

Anything else we need to know?

No response

Kubernetes version

Since 1.26 till at least 1.29.

Cloud provider

n/a

OS version

No response

Install tools

No response

Container runtime (CRI) and version (if applicable)

No response

Related plugins (CNI, CSI, ...) and versions (if applicable)

No response

@pohly pohly added the kind/bug Categorizes issue or PR as related to a bug. label Mar 5, 2024
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Mar 5, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Mar 5, 2024
@neolit123
Copy link
Member

/sig node

@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Mar 5, 2024
@pohly
Copy link
Contributor Author

pohly commented Mar 5, 2024

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/node Categorizes an issue or PR as relevant to SIG Node.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants