New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dra api: fix status updates #123730
dra api: fix status updates #123730
Conversation
Changing object meta is not supposed to be possible via status updates. For example, it circumvents RBAC permission checks.
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
LGTM label has been added. Git tree hash: a3ba056ee596f20b1daa513f464fbfd23924196e
|
should we have a test? I don't know if we are very diligent with existing APIs. |
/lgtm change is straightforward can add a test if you want in response to #123730 (comment) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, pohly The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/sig node |
/sig node |
/milestone v1.30 |
What type of PR is this?
/kind bug
What this PR does / why we need it:
Changing object meta is not supposed to be possible via status updates. For example, it circumvents RBAC permission checks.
Which issue(s) this PR fixes:
Fixes #123727
Special notes for your reviewer:
Found during review of #123516 because it relied on the buggy behavior.
Does this PR introduce a user-facing change?