Use the right feature gate when updating uncertain volumes #124048
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
release-note-none
|
This issue is currently awaiting triage. If a SIG or subproject determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-priority
k8s-ci-robot
added
area/kubelet
sig/node
|
/cc @jsafrane |
|
/test integration |
|
@bertinatto: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/test pull-kubernetes-integration |
k8s-ci-robot
added
release-note
bertinatto
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bertinatto, jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
carlory
reviewed
Mar 26, 2024
| @@ -717,7 +717,7 @@ func (asw *actualStateOfWorld) AddPodToVolume(markVolumeOpts operationexecutor.M | |||
| // Update uncertain volumes - the new markVolumeOpts may have updated information. | |||
| // Especially reconstructed volumes (marked as uncertain during reconstruction) need | |||
| // an update. | |||
| updateUncertainVolume = utilfeature.DefaultFeatureGate.Enabled(features.SELinuxMountReadWriteOncePod) && podObj.volumeMountStateForPod == operationexecutor.VolumeMountUncertain | |||
| updateUncertainVolume = utilfeature.DefaultFeatureGate.Enabled(features.NewVolumeManagerReconstruction) && podObj.volumeMountStateForPod == operationexecutor.VolumeMountUncertain | |||
There was a problem hiding this comment.
features.NewVolumeManagerReconstruction is promoted to GA and lock to default.
Suggested change
| updateUncertainVolume = utilfeature.DefaultFeatureGate.Enabled(features.NewVolumeManagerReconstruction) && podObj.volumeMountStateForPod == operationexecutor.VolumeMountUncertain | |
| updateUncertainVolume = podObj.volumeMountStateForPod == operationexecutor.VolumeMountUncertain |
There was a problem hiding this comment.
Do we want to cherry-pick it into 1.27, 1.28, 1.29 and 1.30? If so, please don't accept my suggestion on code changes and the current change makes senses
There was a problem hiding this comment.
Yeah, I just wanted to fix 1.27-1.29, as you mentioned, 1.30 is locked.
There was a problem hiding this comment.
Hi, @bertinatto Can you help to cherry-pick this PR into the 1.27, 1.28, and 1.29 release branches?
There was a problem hiding this comment.
Hi @carlory; sure, here are the cherry-picks, PTAL:
- 1.27: Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes #124142
- 1.28: Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes #124141
- 1.29: Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes #124140
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 966f7aa8bbcddf7b6c58f2165ca26c24c420c644
|
|
/milestone v1.30 This is a bugfix that would be backported anyway. |
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 5, 2024
…124048-upstream-release-1.27 Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 5, 2024
…124048-upstream-release-1.29 Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes
k8s-ci-robot
added a commit
that referenced
this pull request
Apr 5, 2024
…124048-upstream-release-1.28 Automated cherry pick of #124048: Use the right feature gate when updating uncertain volumes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
Fix by @jsafrane
Which issue(s) this PR fixes:
Fixes #124057
Special notes for your reviewer:
Does this PR introduce a user-facing change?
Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.: