Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCPBUGS-30957: Use the right feature gate when updating uncertain … #1919

Conversation

bertinatto
Copy link
Member

CC @openshift/storage

/hold
until we know this fixes the issue.

@openshift-ci-robot openshift-ci-robot added the backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. label Mar 25, 2024
@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 25, 2024
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Mar 25, 2024
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-30957, which is invalid:

  • expected the bug to target the "4.16.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

CC @openshift/storage

/hold
until we know this fixes the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Mar 25, 2024
@openshift-ci-robot
Copy link

@bertinatto: the contents of this pull request could not be automatically validated.

The following commits could not be validated and must be approved by a top-level approver:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@bertinatto
Copy link
Member Author

/retest-required

@bertinatto
Copy link
Member Author

/hold cancel

@jsafrane
Copy link

jsafrane commented Apr 4, 2024

/lgtm

@jsafrane
Copy link

jsafrane commented Apr 4, 2024

/validate-backports

@openshift-ci-robot openshift-ci-robot added backports/validated-commits Indicates that all commits come to merged upstream PRs. and removed backports/unvalidated-commits Indicates that not all commits come to merged upstream PRs. labels Apr 4, 2024
@openshift-ci-robot
Copy link

@jsafrane: the contents of this pull request could be automatically validated.

The following commits are valid:

Comment /validate-backports to re-evaluate validity of the upstream PRs, for example when they are merged upstream.

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2024
@jsafrane
Copy link

jsafrane commented Apr 5, 2024

Note: both NewVolumeManagerReconstruction and SELinuxMountReadWriteOncePod are enabled by default in 4.16. This fix affects only cases where a cluster admin plays with just one of the gates. Not really useful in 4.16, but we plan backport to 4.14 where both are disabled and enabling NewVolumeManagerReconstruction helps with testing of the feature and with proof of concept work.

Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/jira refresh

Copy link

openshift-ci bot commented Apr 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 5, 2024
@soltysh
Copy link
Member

soltysh commented Apr 5, 2024

Manually fixing jira labels, gh has issues, and I checked it has the correct version set
/remove-label jira/invalid-bug
/label jira/valid-bug

@openshift-ci openshift-ci bot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Apr 5, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD e994e5d and 2 for PR HEAD eabeab9 in total

@soltysh
Copy link
Member

soltysh commented Apr 5, 2024

/retest-requried

@ropatil010
Copy link

Test results added here: https://issues.redhat.com/browse/OCPBUGS-30957#:~:text=Executed%20as%20per%20above%20mentioned%20steps%20and%20able%20to%20reproduce

With this PR, pods are up and running after reboot of node. Adding the label based on the above results.
/label qe-approved
/retest-requried

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label Apr 6, 2024
@openshift-ci-robot
Copy link

@bertinatto: This pull request references Jira Issue OCPBUGS-30957, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.16.0) matches configured target version for branch (4.16.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (wduan@redhat.com), skipping review request.

In response to this:

CC @openshift/storage

/hold
until we know this fixes the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@duanwei33
Copy link

/retest-required

Copy link

openshift-ci bot commented Apr 7, 2024

@bertinatto: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-agnostic-ovn-cmd eabeab9 link false /test e2e-agnostic-ovn-cmd

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@duanwei33
Copy link

/test e2e-aws-ovn-crun

@openshift-merge-bot openshift-merge-bot bot merged commit 0345d5c into openshift:master Apr 7, 2024
18 of 19 checks passed
@openshift-ci-robot
Copy link

@bertinatto: Jira Issue OCPBUGS-30957: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-30957 has been moved to the MODIFIED state.

In response to this:

CC @openshift/storage

/hold
until we know this fixes the issue.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build openshift-enterprise-pod-container-v4.16.0-202404071345.p0.g0345d5c.assembly.stream.el9 for distgit openshift-enterprise-pod.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. backports/validated-commits Indicates that all commits come to merged upstream PRs. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants