Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Step in Documentation for Building Kubernetes in Docker #125511

Open
this-is-yaash opened this issue Jun 14, 2024 · 8 comments
Open

Missing Step in Documentation for Building Kubernetes in Docker #125511

this-is-yaash opened this issue Jun 14, 2024 · 8 comments
Assignees
Labels
kind/documentation Categorizes issue or PR as related to documentation. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@this-is-yaash
Copy link
Contributor

Description

I noticed that the documentation for building Kubernetes in Docker does not include a step to clone the Kubernetes repository. The instructions go straight to executing key scripts, which can be confusing for users who are new to the process. That includes me too, when I'm on-boarding it.

Documentation:

To Make It Better and Understandable to Beginners

To add the follow steps

Cloning the Kubernetes Repository

Before you start building Kubernetes in Docker, make sure to clone the repository using the following command:

git clone https://github.com/kubernetes/kubernetes.git
cd kubernetes

With this, the upcoming guidelines are way too easy to understand after going through this.

@k8s-ci-robot k8s-ci-robot added needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 14, 2024
@k8s-ci-robot
Copy link
Contributor

@this-is-yaash: The label(s) sig/sig/docs cannot be applied, because the repository doesn't have them.

In response to this:

/sig sig/docs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@this-is-yaash
Copy link
Contributor Author

/sig docs

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jun 14, 2024
@this-is-yaash
Copy link
Contributor Author

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 14, 2024
@this-is-yaash
Copy link
Contributor Author

/assign

@mengjiao-liu
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jun 17, 2024
@BenTheElder
Copy link
Member

You're not expected to be starting from this file, we have a broader developer guide.

https://www.kubernetes.dev/docs/guide/

At most we should put a brief pointer, we should not duplicate the docs for setting up your local clone, it is implied that you have to have a checkout.

The clone should be implied here, it is expected that to build an open source project on github you must have the source code locally, and the same for running scripts from the repo.

@BenTheElder
Copy link
Member

BenTheElder commented Jun 18, 2024

https://github.com/kubernetes/kubernetes/blob/master/CONTRIBUTING.md (github standard contributing guide location) which links to https://github.com/kubernetes/community/tree/master/contributors/guide, which will later link to the building docs after cloning etc.

We should probably add a link in the building doc in this repo to this step: https://github.com/kubernetes/community/tree/master/contributors/guide#setting-up-your-development-environment

And maybe also a pointer to CONTRIBUTING.md as that's a better entrypoint if you're planning to contribute.

@BenTheElder
Copy link
Member

/remove-sig docs
/sig release contributor-experience

(SIG docs maintains kubernetes.io, they don't necessarily maintain all documentation in the project, such as the contributor guides, which are contribex or the SIGs for which the development is being done)

@k8s-ci-robot k8s-ci-robot added sig/release Categorizes an issue or PR as relevant to SIG Release. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. and removed sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. sig/contributor-experience Categorizes an issue or PR as relevant to SIG Contributor Experience. sig/release Categorizes an issue or PR as relevant to SIG Release. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

4 participants