Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark QoS as an experimental feature #15317

Merged
merged 1 commit into from
Oct 9, 2015
Merged

Mark QoS as an experimental feature #15317

merged 1 commit into from
Oct 9, 2015

Conversation

vishh
Copy link
Contributor

@vishh vishh commented Oct 8, 2015

@bgrant0607: Updated doc as discussed offline.

Given that #14943 is still under debate, I have opened this PR to mark QoS as an experimental feature in v1.1. I intend to cherry-pick this PR into the v1.1 release branch.
cc @derekwaynecarr

@bgrant0607 bgrant0607 self-assigned this Oct 8, 2015
@bgrant0607
Copy link
Member

Just referring to offline discussion is not helpful. Should have at least referenced the prior PR: #14943.

Please add the references mentioned in the previous PR.

Citing the split hierarchy issue as an example would help people understand why it's not fully baked. This is too terse.

@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 8, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/XS

@k8s-bot
Copy link

k8s-bot commented Oct 8, 2015

GCE e2e test build/test passed for commit 7ae9560b010fbf4a6f1f9bf374861a6cbf2fb027.

@vishh vishh force-pushed the qos-update branch 2 times, most recently from b268c1b to 38e813f Compare October 8, 2015 20:10
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 8, 2015
@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-bot
Copy link

k8s-bot commented Oct 8, 2015

GCE e2e test build/test passed for commit b268c1b7e5cf7acbf67e4262287e2fa95d414313.

@k8s-bot
Copy link

k8s-bot commented Oct 8, 2015

GCE e2e test build/test passed for commit 38e813f9bea5f5319aa02cc375d8bbfb8b18021e.

@vishh
Copy link
Contributor Author

vishh commented Oct 8, 2015

@bgrant0607: Updated the PR to include a few major issues.

@vishh vishh mentioned this pull request Oct 8, 2015
Merged
@k8s-bot
Copy link

k8s-bot commented Oct 8, 2015

GCE e2e test build/test passed for commit 955f896.

@derekwaynecarr
Copy link
Member

LGTM

On Thursday, October 8, 2015, Kubernetes Bot notifications@github.com
wrote:

GCE e2e test build/test passed for commit 955f896
955f896
.

—
Reply to this email directly or view it on GitHub
#15317 (comment)
.

@k8s-github-robot k8s-github-robot added the kind/design Categorizes issue or PR as related to design. label Oct 9, 2015
@bgrant0607
Copy link
Member

Ok.

@bgrant0607 bgrant0607 added lgtm "Looks good to me", indicates that a PR is ready to be merged. e2e-not-required labels Oct 9, 2015
@k8s-github-robot
Copy link

Automatic merge from submit-queue

k8s-github-robot pushed a commit that referenced this pull request Oct 9, 2015
Merge pull request #15317 from vishh/qos-update
e8ae489 
Auto commit by PR queue bot
@k8s-github-robot k8s-github-robot merged commit e8ae489 into kubernetes:master Oct 9, 2015
@k8s-github-robot
Copy link

@k8s-bot test this [submit-queue is verifying that this PR is safe to merge]

xingzhou pushed a commit to xingzhou/kubernetes that referenced this pull request Dec 15, 2016
Merge pull request kubernetes#15317 from vishh/qos-update
ed06fad 
Auto commit by PR queue bot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
kind/design Categorizes issue or PR as related to design. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@vishh @bgrant0607 @k8s-github-robot @k8s-bot @derekwaynecarr @googlebot @eparis