Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kubelet should enforce maxPods #20263

Closed
davidopp opened this issue Jan 28, 2016 · 1 comment
Closed

Kubelet should enforce maxPods #20263

davidopp opened this issue Jan 28, 2016 · 1 comment
Assignees
@gmarek
Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@davidopp
Copy link
Member

Was there some reason #5547 only added the checking to the scheduler, not Kubelet?

@gmarek
@davidopp davidopp added priority/backlog Higher priority than priority/awaiting-more-evidence. team/control-plane labels Jan 28, 2016
@gmarek
Copy link
Contributor

gmarek commented Jan 28, 2016

IIRC it was written at the time when we stated adding checking in Kubelet. In other words - no reason.

@davidopp davidopp mentioned this issue Feb 15, 2016
Merged
@davidopp davidopp mentioned this issue Apr 22, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Apr 23, 2016
Merge pull request #24674 from gmarek/maxpods
2ec9080 
Automatic merge from submit-queue

Enforce --max-pods in kubelet admission; previously was only enforced in scheduler

This is an ugly hack - I spent some time trying to understand what one NodeInfo has in common with the other one, but at some point decided that I just don't have time to do that.

Fixes #24262
Fixes #20263

cc @HaiyangDING @lavalamp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmarek gmarek

Labels
priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gmarek @davidopp