Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix kubectl create to create to all resources in a url. #22009

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Fix kubectl create to create to all resources in a url. #22009

merged 1 commit into from
Mar 3, 2016

Conversation

aveshagarwal
Copy link
Member

Fixes #18751 .

@aveshagarwal
Copy link
Member Author

@kubernetes/rh-cluster-infra

@k8s-github-robot
Copy link

Labelling this PR as size/S

@k8s-github-robot k8s-github-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 25, 2016
@k8s-bot
Copy link

k8s-bot commented Feb 25, 2016

GCE e2e build/test passed for commit f4dd51479f0bc8ebf8003384f6a0b73250e338f2.

@k8s-github-robot
Copy link

The author of this PR is not in the whitelist for merge, can one of the admins add the 'ok-to-merge' label?

@aveshagarwal
Copy link
Member Author

it seems it needs LGTM too.

@bgrant0607
Copy link
Member

cc @kubernetes/kubectl

@bgrant0607 bgrant0607 assigned smarterclayton and unassigned janetkuo Mar 1, 2016
@bgrant0607
Copy link
Member

@smarterclayton Do you have time to take a quick look?

@bgrant0607 bgrant0607 added this to the v1.2 milestone Mar 1, 2016
@bgrant0607 bgrant0607 added kind/bug Categorizes issue or PR as related to a bug. priority/backlog Higher priority than priority/awaiting-more-evidence. labels Mar 1, 2016
@0xmichalis
Copy link
Contributor

Needs a test

@aveshagarwal
Copy link
Member Author

Updated it with a test case.

@k8s-github-robot
Copy link

Labelling this PR as size/M

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 2, 2016
@k8s-bot
Copy link

k8s-bot commented Mar 2, 2016

GCE e2e build/test passed for commit c1ea4d645eb96ef1f63759e0b922b0f369537b36.

@0xmichalis
Copy link
Contributor

@aveshagarwal can you also exercise create in test-cmd.sh?

@aveshagarwal
Copy link
Member Author

Added a test case to hack/test-cmd.sh and updated PR.

@k8s-bot
Copy link

k8s-bot commented Mar 2, 2016

GCE e2e build/test failed for commit ad6dfa0.

Please reference the list of currently known flakes when examining this failure. If you request a re-test, you must reference the issue describing the flake.

@aveshagarwal
Copy link
Member Author

Flakes:

[Fail] Deployment [It] RecreateDeployment should delete old pods and create new ones 
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/deployment.go:380

[Fail] Deployment [It] RollingUpdateDeployment should delete old pods and create new ones 
/go/src/k8s.io/kubernetes/_output/dockerized/go/src/k8s.io/kubernetes/test/e2e/deployment.go:268

@j3ffml
Copy link
Contributor

j3ffml commented Mar 3, 2016

@k8s-bot test this please issue: #22300

@k8s-bot
Copy link

k8s-bot commented Mar 3, 2016

GCE e2e build/test passed for commit ad6dfa0.

@0xmichalis
Copy link
Contributor

LGTM

@0xmichalis
Copy link
Contributor

@bgrant0607 please tag this as lgtm

@bgrant0607 bgrant0607 added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2016
@bgrant0607
Copy link
Member

@Kargakis Done. Thanks for the review.

j3ffml added a commit that referenced this pull request Mar 3, 2016
@j3ffml
Merge pull request #22009 from aveshagarwal/master-create-urls-issue
afa7816 
Fix kubectl create to create to all resources in a url.
@j3ffml j3ffml merged commit afa7816 into kubernetes:master Mar 3, 2016
@aveshagarwal aveshagarwal deleted the master-create-urls-issue branch March 4, 2016 16:04
@jeffmendoza jeffmendoza mentioned this pull request Mar 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@0xmichalis 0xmichalis

Labels
area/kubectl kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/backlog Higher priority than priority/awaiting-more-evidence. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@aveshagarwal @k8s-github-robot @k8s-bot @bgrant0607 @0xmichalis @j3ffml @k8s-teamcity-mesosphere @smarterclayton @janetkuo @googlebot