Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up validation code #2238

Closed
dchen1107 opened this issue Nov 7, 2014 · 4 comments
Closed

Clean up validation code #2238

dchen1107 opened this issue Nov 7, 2014 · 4 comments
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@dchen1107
Copy link
Member

Validation code should only do validation, shouldn't also set default value. The default value setting should be done in conversion since it matters in different api version.
@dchen1107 dchen1107 added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Nov 7, 2014
@dchen1107
Copy link
Member Author

One example is RestartPolicy.

@thockin
Copy link
Member

thockin commented Nov 7, 2014

This is related to the "consistent defaulting" issue. Agree.

On Fri, Nov 7, 2014 at 12:25 PM, Dawn Chen notifications@github.com wrote:

One example is RestartPolicy.

Reply to this email directly or view it on GitHub
#2238 (comment)
.

@roberthbailey roberthbailey added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Dec 10, 2014
@bgrant0607
Copy link
Member

Done. We now have a defaulting pass.

@bgrant0607
Copy link
Member

See #1502 for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@thockin @bgrant0607 @dchen1107 @roberthbailey @davidopp