Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadbalancing umbrella issue #24145

Closed
3 of 17 tasks
bprashanth opened this issue Apr 12, 2016 · 14 comments
Closed
3 of 17 tasks

Loadbalancing umbrella issue #24145

bprashanth opened this issue Apr 12, 2016 · 14 comments
Assignees
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.

Comments

@bprashanth
Copy link
Contributor

bprashanth commented Apr 12, 2016

A non-comprehensive list ordered by an approximation of priority. Mostly for documentation and reducing bus factor:

@kubernetes/goog-cluster

@bprashanth bprashanth added sig/network Categorizes an issue or PR as relevant to SIG Network. team/cluster labels Apr 12, 2016
@sputnik13
Copy link

created #27294 to address sharing of IPs, hostnames, and other "things" in an Ingress

@pires
Copy link
Contributor

pires commented Jul 5, 2016

Who's responsible for updating this issue? For instance, the first item in the list is fixed.

@bprashanth
Copy link
Contributor Author

@pires that's rigth, as is

Let different controllers co-exist

The gce controller will ignore any ingress with the annotation kubernetes.io/ingress.class=gce, I still need to implement that for nginx.

Health checks - just scrape endpoints for http readiness?

Both nginx and gce will scrape your endpoints (the endpoint pods corresponding to the serviceName:servicePort in your Ingress) for an HTTP probe that doesn't require any special http headers or https. If one is found it's used for the health check, otherwise it defaults to "/"

Cert generation

Kube-lego currently only works with the nginx ingress controller, the idea is to get it to work with everything.

Improve e2es (write a single generic E2E for nginx/aws/gce)

A generic cross platform e2e was written: https://github.com/kubernetes/kubernetes/blob/master/test/e2e/ingress.go#L175

E2es could always use improvement though. The next step is to write e2es for nginx and add that to presubmit.

I'll updated it soon there are a couple of points i need to add to the list

@girishkalele
Copy link

Adding to this list

#28647 Source IP Preservation for external LB services.

@nvnobelen
Copy link

@pires Just tested 1.4-alpha2 for issue #10921/#28467: Does not work in alpha2 as expected (or do I misinterpret the state "closed" here as something is really in the branch):

Log output in an nginx container:

174.6.xx.xx 1 0.000 [12/Aug/2016:21:01:25 +0000]  "GET /favicon.ico HTTP/1.1" 404 199 "http://104.154.234.227/" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/51.0.2704.79 Chrome/51.0.2704.79 Safari/537.36" "-" "-"
10.240.0.7 2 0.000 [12/Aug/2016:21:01:25 +0000]  "GET / HTTP/1.1" 200 4 "-" "Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/51.0.2704.79 Chrome/51.0.2704.79 Safari/537.36" "-" "-"

Source info/bug report in #30531

@bprashanth
Copy link
Contributor Author

@nvnobelen source ip was never preserved for ingress traffic through services.Type=LoadBalancer. That's what #24145 (comment) is about. For intra cluster traffic through the service vip, you should see the right source ip of the pod in nginx logs, if that doesn't work it's a regression (#27110). If you're using a hostPort pod, you may get source ip, this is a live bug (#29742), but you will get the right source ip in the case that matters most (outside cluster -> node ip:hostport).

@sandys
Copy link

sandys commented Nov 16, 2016

@bprashanth is there a bug to preserve source ip for nginx based ingress controllers ? i see lots of bugs in different cases.. but not for nginx ingress.

@pires
Copy link
Contributor

pires commented Nov 16, 2016

@thockin can we have an owner for this issue?

@ConnorJC3
Copy link
Contributor

Is there an issue for source IP preservation on non-GCE clusters?

@bprashanth
Copy link
Contributor Author

It needs to be dealt with on a case by case basis (eg #35758)

@thockin
Copy link
Member

thockin commented Nov 24, 2016 via email

@InAnimaTe
Copy link

Any updates on this? Has it been merged to docs or discrete bugs?

Additionally, unless I'm reading this wrong, it seems SNI Passthrough (L4 in Ingress) is at least somewhat done.

@pires
Copy link
Contributor

pires commented Feb 20, 2017

The L4 Ingress proposal was closed due to inactivity. The somewhat done you mention is just a workaround for nginx controller.

@bowei
Copy link
Member

bowei commented Sep 19, 2017

I'm going to close this bug in favor the individual pieces that are planned and in progress.

/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/network Categorizes an issue or PR as relevant to SIG Network.
Projects
None yet
Development

No branches or pull requests