Google Cloud DNS dnsprovider - replacement for #25389

[ghost]

Add Google Cloud DNS dnsprovider.

[ghost]

I somehow messed up my local git repo - the easiest way to fix it was to create this new PR, which replaces #25389.

[ghost]

Seeing as this is identical to #25389, reapplying LGTM here.

[ghost]

@mfanjie FYI

[ghost]

Fixed boilerplate comment in rrstype.go. Will reapply LGTM.

[ghost]

google.golang.org/api/dns is missing from the vendor tree. Investigating...

federation/pkg/dnsprovider/providers/google/clouddns/clouddns.go:27:2: cannot find package "google.golang.org/api/dns/v1" in any of:
    /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/google.golang.org/api/dns/v1 (vendor tree)

[ghost]

Blocked on #26026

[ghost]

@nikhiljindal FYI, as you're doing such a marvellous job of shepherding the cluster federation PR's through the pipeline.

[bprashanth]

fyi

federation/pkg/dnsprovider/providers/google/clouddns/clouddns.go:27:2: cannot find package "google.golang.org/api/dns/v1" in any of:
    /go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/vendor/google.golang.org/api/dns/v1 (vendor tree)
    /usr/local/go/src/google.golang.org/api/dns/v1 (from $GOROOT)
    /go/src/k8s.io/kubernetes/_output/local/go/src/google.golang.org/api/dns/v1 (from $GOPATH)
+++ [0521 12:04:18] Saved JUnit XML test report to /workspace/artifacts/junit_v1,extensions-v1beta1,metrics-v1alpha1,federation-v1alpha1_20160521-120417.xml
!!! Error in ./hack/test-go.sh:241

[ghost]

@bprashanth Yes, thanks, that's why it's blocked on #26026

[ghost]

OK, dependency issues should be resolved now. Hopefully this will auto-merge as soon as the merge-bot is working again.

[ghost]

Same problem as #26026

Verifying ./hack/../hack/verify-godep-licenses.sh
Checking for 'Godeps/' changes against 'origin/master'
Created workspace: /go/src/k8s.io/kubernetes/_tmp/kube-godep-licenses.UNebSp
Your godep licenses file is out of date. Run hack/update-godep-licenses.sh --create-missing and commit the results.
--- /go/src/k8s.io/kubernetes/Godeps/LICENSES   2016-05-24 13:37:08.800171089 -0700
+++ /go/src/k8s.io/kubernetes/_tmp/kube-godep-licenses.UNebSp/Godeps/LICENSES   2016-05-24 13:53:40.696567852 -0700
@@ -64925,6 +64925,38 @@ OF THIS SOFTWARE, EVEN IF ADVISED OF THE


 ================================================================================
+= vendor/google.golang.org/api/dns/v1 licensed under: =
+
+Copyright (c) 2011 Google Inc. All rights reserved.
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are
+met:
+
+   * Redistributions of source code must retain the above copyright
+notice, this list of conditions and the following disclaimer.
+   * Redistributions in binary form must reproduce the above
+copyright notice, this list of conditions and the following disclaimer
+in the documentation and/or other materials provided with the
+distribution.
+   * Neither the name of Google Inc. nor the names of its
+contributors may be used to endorse or promote products derived from
+this software without specific prior written permission.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+(INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+
+
+================================================================================
 = vendor/google.golang.org/api/gensupport licensed under: =

 Copyright (c) 2011 Google Inc. All rights reserved.
Removing workspace: /go/src/k8s.io/kubernetes/_tmp/kube-godep-licenses.UNebSp
FAILED   ./hack/../hack/verify-godep-licenses.sh    15s

[k8s-github-robot]

@quinton-hoole
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

[ghost]

@k8s-bot test this issue: #26270

[ghost]

Re-applying LGTM

[zmerlynn]

I don't see a P0 issue opened for this, but this will quickly bring us out of license compliance, perhaps with this PR itself.

cc @david-mcmahon @lavalamp

[zmerlynn]

Please open a P0 issue on the license issue and reapply LGTM.

[ghost]

Thanks @zmerlynn.
I opened #26328

[alex-mohr]

I have a few questions about this PR I'd like to get answered before we merge, so removed LGTM. Please don't re-apply until then.

[madhusudancs]

@alex-mohr where are the questions?

[david-mcmahon]

@quinton-hoole I cannot repro, but I suspect I'm not putting this together correctly:

$ git fetch origin pull/26020/head:pr-26020
$ git checkout pr-26020
$ vi hack/verify-godep-licenses.sh # and remove the exit 0 from this PR
$ hack/verify-godep-licenses.sh
$ echo $?
1
$ hack/update-godep-licenses.sh
$ hack/verify-godep-licenses.sh
$ echo $?
0

It should be easy enough to remove the jq requirement and bash 4 has been out for 7 years. How was that not updated yet?

[ghost]

OK, I removed all of the {verify|update}-godep-license.sh related stuff in this PR, as the fixes for that are in #26348 (which should merge shortly).

All that's required here now is (I hope) to rebase against HEAD once #26348 is in, run hack/update-godep-license.sh, and commit the results. I'll shepherd that through.

[ghost]

OK @madhusudancs @nikhiljindal I've rebased against the above and regenerated godeps licenses. I think this is good to merge now, once tests pass.

[k8s-github-robot]

@quinton-hoole
You must link to the test flake issue which caused you to request this manual re-test.
Re-test requests should be in the form of: k8s-bot test this issue: #<number>
Here is the list of open test flakes.

[k8s-bot]

GCE e2e build/test passed for commit 2240da1.

• Build Log
• Test Artifacts
• Internal Jenkins Results

[mfanjie]

@mfanjie notify me

[ghost]

All tests have passed. Merge queue is blocked, so manually merging, as this is a v1.3 blocker, with several other blocker PR's waiting for it to merge.

[ghost]

@mfanjie FYI, merged.

[mfanjie]

working on it.