Federation service controller #26034

mfanjie · 2016-05-22T02:34:42Z

Federation service controller is one key component of federation controller manager, it watches federation service, creates/updates services to all registered clusters, and update DNS records to global DNS server.

k8s-bot · 2016-05-22T02:35:15Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-05-22T02:36:11Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

k8s-bot · 2016-05-22T02:36:28Z

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in kubernetes/test-infra/jenkins/job-configs/kubernetes-jenkins-pull instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

mfanjie · 2016-05-22T02:37:50Z

@quinton-hoole I created this PR based on #26020, when you finish code review on the wip #26034, I will update all changes on both branches, so we can be ready for code merge.

ghost · 2016-05-22T02:59:51Z

ok to test

ghost · 2016-05-22T03:01:29Z

Thanks @mfanjie !

ghost · 2016-05-22T20:06:09Z

Fixes #23848

ghost · 2016-05-22T20:08:45Z

Still a few minor govet and flags issues to resolve, then LGTM.

FAILED   ./hack/../hack/verify-gofmt.sh 9s
Verifying ./hack/../hack/verify-govet.sh
federation/pkg/federation-controller/service/endpoint_helper.go:38: range variable clusterCache captured by func literal
federation/pkg/federation-controller/service/endpoint_helper.go:43: range variable clusterCache captured by func literal
federation/pkg/federation-controller/service/endpoint_helper.go:44: range variable clusterName captured by func literal
federation/pkg/federation-controller/service/endpoint_helper.go:44: range variable clusterCache captured by func literal
federation/pkg/federation-controller/service/service_helper.go:41: range variable clusterCache captured by func literal
federation/pkg/federation-controller/service/service_helper.go:46: range variable clusterCache captured by func literal
federation/pkg/federation-controller/service/service_helper.go:47: range variable clusterName captured by func literal
federation/pkg/federation-controller/service/service_helper.go:47: range variable clusterCache captured by func literal
federation/pkg/federation-controller/service/servicecontroller.go:291: range variable clusterName captured by func literal
federation/pkg/federation-controller/service/servicecontroller.go:291: range variable cluster captured by func literal
federation/pkg/federation-controller/service/endpoint_helper_test.go:32: k8s.io/kubernetes/pkg/api/v1.EndpointAddress composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:32: k8s.io/kubernetes/pkg/api/v1.LoadBalancerIngress composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:56: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:64: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:66: k8s.io/kubernetes/pkg/api/v1.LoadBalancerIngress composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:69: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:81: k8s.io/kubernetes/pkg/api/v1.LoadBalancerIngress composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:84: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:92: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:97: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:129: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:131: k8s.io/kubernetes/pkg/api/v1.LoadBalancerIngress composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:134: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:142: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:148: k8s.io/kubernetes/pkg/api/v1.ServiceStatus composite literal uses unkeyed fields
FAILED   ./hack/../hack/verify-govet.sh 89s

Verifying ./hack/../hack/verify-flags-underscore.py
Found flags in golang files not in the list of known flags. Please add these to hack/verify-flags/known-flags.txt
concurrent-service-syncs
FAILED   ./hack/../hack/verify-flags-underscore.py  5s

mfanjie · 2016-05-23T04:14:22Z

resolved above problems and squashed commit.

nikhiljindal · 2016-05-23T05:07:05Z

verify-govet is still failing. From logs:

Verifying ./hack/../hack/verify-govet.sh
federation/pkg/federation-controller/service/endpoint_helper_test.go:32: k8s.io/kubernetes/pkg/api/v1.EndpointAddress composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:31: k8s.io/kubernetes/pkg/api/v1.LoadBalancerIngress composite literal uses unkeyed fields
FAILED   ./hack/../hack/verify-govet.sh

ghost · 2016-05-23T05:07:18Z

@mfanjie govet is still not quite happy

Verifying ./hack/../hack/verify-govet.sh
federation/pkg/federation-controller/service/endpoint_helper_test.go:32: k8s.io/kubernetes/pkg/api/v1.EndpointAddress composite literal uses unkeyed fields
federation/pkg/federation-controller/service/service_helper_test.go:31: k8s.io/kubernetes/pkg/api/v1.LoadBalancerIngress composite literal uses unkeyed fields
FAILED   ./hack/../hack/verify-govet.sh 101s

ghost · 2016-05-23T05:07:50Z

Snap :-)

mfanjie · 2016-05-23T05:10:43Z

acked, it is strange that I can not get these two errors when I ran govet.sh on my laptop...
@quinton-hoole One thing I am not sure about it that should we use internalclient instead of release_1_3 as you discussed in the wip PR.
I am trying to make that change and seems I got no error with internalclient, I will leave it as is now.

mfanjie · 2016-05-23T05:21:30Z

pushed again, I will monitor the e2e result.

nikhiljindal · 2016-05-26T22:51:51Z

federation/pkg/federation-controller/service/servicecontroller.go

+	s.queue.Add(key)
+}
+
+// Run starts a background goroutine that watches for changes to Federated services


federation services

nikhiljindal · 2016-05-26T22:53:12Z

Still trying to understand the code. Have added a few comments.

nikhiljindal · 2016-05-26T23:00:04Z

cc @kubernetes/sig-cluster-federation

mfanjie · 2016-05-27T02:32:49Z

@nikhiljindal all your comments addressed.

ghost · 2016-05-27T22:53:39Z

LGTM! Needs to rebase against upstream/maser once #26020 merges (hopefully within the next few hours at most). Then ready for merge, once checks all pass.

ghost · 2016-05-28T15:15:46Z

@mfanjie If you rebase this I should be able to merge it now.

mfanjie · 2016-05-28T15:31:14Z

@quinton-hoole rebased and pushed

mfanjie · 2016-05-28T16:07:07Z

failed for one checking, working on it.

In addition, I found some error on clustercontroller.go, even it is not related to this PR but it impacts the cluster status, so we have to manually update the cluster status to make service controller working properly, opened issue #26480 .

ghost · 2016-05-28T16:27:36Z

Thanks @mfanjie. As soon as the checks pass, I'll merge this.

k8s-bot · 2016-05-28T17:19:34Z

GCE e2e build/test passed for commit 089325a529d5888e119de6cd0f5f8c3aeca0cf90.

ghost · 2016-05-28T18:25:12Z

All checks have passed. Merge queue is blocked, so manually merging, as this is a v1.3 blocker, with several other blocker PR's waiting for it to merge.

mfanjie · 2016-06-08T04:45:38Z

this is a sub task of #23653 , add linkage.

fd · 2016-06-10T12:10:15Z

federation/cmd/federation-controller-manager/app/options/options.go

+	// dnsProvider is the provider for dns services.
+	DnsProvider string `json:"dnsProvider"`
+	// dnsConfigFile is the path to the dns provider configuration file.
+	DnsConfigFile string `json:"ndsConfigFile"`


@quinton-hoole @mfanjie ndsConfigFile probably should be dnsConfigFile

(still exists on master)

You are right.
Being fixed in #27158

Though the json field name is not useful yet.

googlebot added the cla: yes label May 22, 2016

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels May 22, 2016

ghost added area/cluster-federation labels May 22, 2016

ghost added this to the v1.3 milestone May 22, 2016

ghost self-assigned this May 22, 2016

ghost added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label May 22, 2016

ghost added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 22, 2016

This was referenced May 22, 2016

WIP: ubernetes federated service controller. #24009

Closed

[WIP]Fed service controller #25517

Closed

Integrate federated service DNS record management #25991

Merged

mfanjie force-pushed the federation-service-controller branch from 5f44379 to 6b589e3 Compare May 23, 2016 04:11

mfanjie force-pushed the federation-service-controller branch from 6b589e3 to 032e0ab Compare May 23, 2016 04:17

mfanjie force-pushed the federation-service-controller branch from 032e0ab to 25f292d Compare May 23, 2016 05:20

nikhiljindal reviewed May 26, 2016
View reviewed changes

mfanjie force-pushed the federation-service-controller branch from f535db0 to 9d67f9d Compare May 27, 2016 02:32

ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2016

mfanjie force-pushed the federation-service-controller branch from 9d67f9d to 15afaa7 Compare May 28, 2016 15:30

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2016

add federation service controller

6133db3

mfanjie force-pushed the federation-service-controller branch from 089325a to 6133db3 Compare May 28, 2016 16:25

k8s-github-robot added the kind/old-docs label May 28, 2016

ghost added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 28, 2016

k8s-github-robot added the needs-ok-to-merge label May 28, 2016

ghost added the ok-to-merge label May 28, 2016

k8s-github-robot removed the needs-ok-to-merge label May 28, 2016

ghost merged commit eff728a into kubernetes:master May 28, 2016

fd reviewed Jun 10, 2016
View reviewed changes

davidopp mentioned this pull request Jun 12, 2016

Ubernetes Service Controller #23848

Closed

This pull request was closed.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Federation service controller #26034

Federation service controller #26034

mfanjie commented May 22, 2016

k8s-bot commented May 22, 2016

k8s-bot commented May 22, 2016

k8s-bot commented May 22, 2016

mfanjie commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

mfanjie commented May 23, 2016

nikhiljindal commented May 23, 2016

ghost commented May 23, 2016

ghost commented May 23, 2016

mfanjie commented May 23, 2016 •

edited

Loading

mfanjie commented May 23, 2016

nikhiljindal May 26, 2016

nikhiljindal commented May 26, 2016

nikhiljindal commented May 26, 2016

mfanjie commented May 27, 2016

ghost commented May 27, 2016

ghost commented May 28, 2016

mfanjie commented May 28, 2016

mfanjie commented May 28, 2016 •

edited

Loading

ghost commented May 28, 2016

k8s-bot commented May 28, 2016

ghost commented May 28, 2016

mfanjie commented Jun 8, 2016

fd Jun 10, 2016

nikhiljindal Jun 10, 2016

Federation service controller #26034

Federation service controller #26034

Conversation

mfanjie commented May 22, 2016

k8s-bot commented May 22, 2016

k8s-bot commented May 22, 2016

k8s-bot commented May 22, 2016

mfanjie commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

ghost commented May 22, 2016

mfanjie commented May 23, 2016

nikhiljindal commented May 23, 2016

ghost commented May 23, 2016

ghost commented May 23, 2016

mfanjie commented May 23, 2016 • edited Loading

mfanjie commented May 23, 2016

nikhiljindal May 26, 2016

Choose a reason for hiding this comment

nikhiljindal commented May 26, 2016

nikhiljindal commented May 26, 2016

mfanjie commented May 27, 2016

ghost commented May 27, 2016

ghost commented May 28, 2016

mfanjie commented May 28, 2016

mfanjie commented May 28, 2016 • edited Loading

ghost commented May 28, 2016

k8s-bot commented May 28, 2016

ghost commented May 28, 2016

mfanjie commented Jun 8, 2016

fd Jun 10, 2016

Choose a reason for hiding this comment

nikhiljindal Jun 10, 2016

Choose a reason for hiding this comment

mfanjie commented May 23, 2016 •

edited

Loading

mfanjie commented May 28, 2016 •

edited

Loading