Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to get kargo project into kubernetes github tree ? #27948

Closed
Smana opened this issue Jun 23, 2016 · 24 comments
Closed

How to get kargo project into kubernetes github tree ? #27948

Smana opened this issue Jun 23, 2016 · 24 comments

Comments

@Smana
Copy link

Smana commented Jun 23, 2016

Hi guys, i'm one of the leader of kubespray organisation and we think our project is mature enough to get included into kubernetes github tree.
Does it make sense for you ?
How to proceed please ?

Regards,
Smana

@Smana
Copy link
Author

Smana commented Jun 23, 2016

@zen
Copy link

zen commented Jun 23, 2016

I second that. Kargo is mature enough and considering idea to switch to ansible in k8s, I'd love to see collaboration here. Many companies are already investing in kargo, so it would be good to attract more contributors in this area.

@pigmej
Copy link
Contributor

pigmej commented Jun 23, 2016

+1 This certainly makes sense to me, especially because there are plans to switch to ansible.

@mattymo
Copy link

mattymo commented Jun 23, 2016

+1 from me as well. Kargo really leads among other ansible-based playbooks in distro support. It's deploying well on Ubuntu Xenial using Calico. This project is really quite active and deserves a good home in the Kubernetes ecosystem.

@rsmitty
Copy link

rsmitty commented Jun 23, 2016

I'll jump in as well as a Kubespray and a contrib/ansible contributor. We had some back and forth about this in the Kubespray slack yesterday and this morning. It really seems that it would be helpful if the contrib/ansible playbooks supported more than they currently do. I personally have been using Kubespray because of this (supports Ubuntu, dynamic numbers of etcd, nodes, etc.). It may make sense to work to integrate the best practices between these two projects and offer them as the contrib/ansible playbooks instead.

Also of interest may be this comparison between the projects from @mattymo https://docs.google.com/spreadsheets/d/1psWdzg88Roat1VQWqWuCTZA-XAP9DoIW_wAQOi6PtD0/edit#gid=0

@yoojinl
Copy link

yoojinl commented Jun 23, 2016

Kubernetes community would definitely benefit from having a single set of well tested Ansible playbooks, for me the most important things in Kubespray were good Ubuntu support and configurable networking backend (e.g. Calico).

@girishkalele
Copy link

cc @goltermann @kelseyhightower FYI

@idvoretskyi
Copy link
Member

As @jbeda has created a feature proposal for the similar question, I'd like to reference it here and propose to evaluate Kagro as a good solution for the described items.

kubernetes/enhancements#11

@idvoretskyi
Copy link
Member

@Smana also, if you'd like to see Kargo as a part of Kubernetes upstream project, please, fill the feature request here - https://github.com/kubernetes/features.

@justinsb
Copy link
Member

I think it would be welcome in https://github.com/kubernetes/kube-deploy, which is where we're putting all the installation/management tools.

@rsmitty
Copy link

rsmitty commented Jun 23, 2016

My understanding of that feature request is that @jbeda is wanting to add a lot of the deployment logic into Kubernetes itself. As in, it becomes part of the golang stuff. At which point Kubespray could just be a set of ansible to call the proper kube commands or something.

That sounds long-term to me though, so Kubespray in the meantime could remain as-is.

@jbeda
Copy link
Contributor

jbeda commented Jun 23, 2016

@rsmitty has it right. I'd like to dramatically reduce the amount of stuff that you'd have to do with something like ansible.

There is still room for automation for bringing up a cluster (creating cloud VMs, advanced configs, etc.) but the "manual" steps should be minimial for a minimal cluster.

@ant31
Copy link
Member

ant31 commented Jun 23, 2016

@justinsb Having one uniq repo for all tools, is harder to watch/follow ticket / commit for it's own project.

@roberthbailey
Copy link
Contributor

I'll second what @justinsb said above -- we are currently trying to extract the deployment logic from the main repo, and are unlikely to accept large new chunks of deployment code into the main repo.

@ant31
Copy link
Member

ant31 commented Jun 23, 2016

@roberthbailey I think what @Smana is asking is to move kargo repo under kubernetes organization.
The project is very active and have good support already by different companies.

Moving in kubernetes organization will help to gather forces on 'ansible' base deploy scripts.

@rsmitty
Copy link

rsmitty commented Jun 23, 2016

It seems to me that it would be helpful to have different types of deployments in their own repos though (and under the kubernetes namespace). This would look like kubernetes/deploy-ansible (which is the kargo playbooks + contrib/ansible ), kubernetes/deploy-salt, kubernetes/deploy-$CM_TOOL. Having a variety of supported, robust ways that appear official to new users seems valuable, as well as offering easier management for these repos. The kubernetes/contrib repo, for example, is tough to spot ansible specific issues in.

@idvoretskyi
Copy link
Member

@rsmitty making the process easier is a goal #1 for us. I'm solidly voting for Kargo to be added to the Kubernetes GitHub but may agree with @justinsb and @roberthbailey that it would be better to place the code itself somewhere (outside of the core repo).

For sure, Kargo has to be actively maintained within the specific repo at Kubernetes GitHub organization and be fully documented as an ability to deploy Kubernetes on http://kubernetes.io/docs/.

@rsmitty
Copy link

rsmitty commented Jun 23, 2016

@idvoretskyi I think we're actually advocating the same thing. I don't think that kubespray (or any deployment tools) should be in the core repo at https://github.com/kubernetes/kubernetes.

I do, however, think that we should have many other deployment related repos under the kubernetes namespace in github. Example, where you see all repos listed at https://github.com/kubernetes, we should present some robust deployment options that are easily found and in their own repo. Thus we'd have something like:

 https://github.com/kubernetes/kubernetes
...
 https://github.com/kubernetes/kubedash
...
 https://github.com/kubernetes/deploy-ansible
 https://github.com/kubernetes/deploy-salt
 https://github.com/kubernetes/deploy-puppet

or whatever people are willing to create and maintain. I would also push towards some requirement that these projects be extremely well maintained and serve as absolute best practices for deployment.

@ant31
Copy link
Member

ant31 commented Jun 23, 2016

I suggest to:

  1. Transfer kubespray/kargo to kubernetes/kargo
  2. Add current kargo documentation to http://kubernetes.io/docs/
  3. Discuss to rename it deploy-ansible and join forces with other authors (contrib/ansible)

Proposal kubernetes/enhancements#11 seems great, we can probably participate and help on it at different level.

@Smana
Copy link
Author

Smana commented Jun 23, 2016

Hi guys,

I totally agree with @ant31 and @rsmitty :
a distinct repository kubernetes/deploy-ansible would be ideal.
Then we'll try to work with the contrib/ansible guys to merge our efforts.
What suggested ant31 is a good start IMO.

Anyway we'll try to help on kubernetes/enhancements#11 and participate to the sig-cluster-lifecycle.

@Smana
Copy link
Author

Smana commented Jun 23, 2016

though the name kargo could be kept, to be discussed.

@bgrant0607
Copy link
Member

Please discuss this in kubernetes-sig-cluster-lifecycle@googlegroups.com.

@bgrant0607
Copy link
Member

In general, we are moving to small, focused repos. If this were moved to the kubernetes github org (which would donate it to CNCF), then it would be in its own repo.

@Smana
Copy link
Author

Smana commented Jun 24, 2016

yes that would be the idea, moving to kubernetes org on a distinct repo @bgrant0607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests