Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TestNamespaceController {namespace} #30855

Closed
k8s-github-robot opened this issue Aug 18, 2016 · 0 comments
Closed

TestNamespaceController {namespace} #30855

k8s-github-robot opened this issue Aug 18, 2016 · 0 comments
Assignees
@spxtr @mwielgus
Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@k8s-github-robot
Copy link

https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/kubernetes-test-go/15909/

Failed: TestNamespaceController {namespace}

<autogenerated>:31: 

    Error Trace:    namespace_controller_test.go:86

    Error:      Expected value not to be nil.

panic: runtime error: invalid memory address or nil pointer dereference
/usr/local/go/src/runtime/panic.go:481 +0x3ff
/usr/local/go/src/testing/testing.go:467 +0x22a
/usr/local/go/src/runtime/panic.go:443 +0x521
/go/src/k8s.io/kubernetes/_output/local/go/src/k8s.io/kubernetes/federation/pkg/federation-controller/namespace/namespace_controller_test.go:87 +0x1a48
/usr/local/go/src/testing/testing.go:473 +0xdd
/usr/local/go/src/testing/testing.go:582 +0xae3
@k8s-github-robot k8s-github-robot added priority/backlog Higher priority than priority/awaiting-more-evidence. kind/flake Categorizes issue or PR as related to a flaky test. labels Aug 18, 2016
@mwielgus mwielgus self-assigned this Aug 18, 2016
@mwielgus mwielgus mentioned this issue Aug 18, 2016
Merged
k8s-github-robot pushed a commit that referenced this issue Aug 18, 2016
Merge pull request #30872 from mwielgus/fed-informer-deadlock
b15c2d6 
Automatic merge from submit-queue

Fix deadlock possibility in federated informer

On cluster add subinformer locks and tries to add cluster to federated informer. When someone checks if everything is in sync federated informer is locked and then subinformer is inspected what apparently requires a lock. With really bad timing this can create a deadlock.

This PR ensures that there is always at most 1 lock taken in federated informer.

cc: @quinton-hoole @kubernetes/sig-cluster-federation 

Fixes: #30855
@k8s-github-robot k8s-github-robot mentioned this issue Sep 30, 2016
Closed
@k8s-github-robot k8s-github-robot mentioned this issue Nov 7, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spxtr spxtr

@mwielgus mwielgus

Labels
kind/flake Categorizes issue or PR as related to a flaky test. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@spxtr @mwielgus @k8s-github-robot