Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SubjectAccessReview typos groups field name #32709

Closed
liggitt opened this issue Sep 14, 2016 · 2 comments · Fixed by #40709
Closed

SubjectAccessReview typos groups field name #32709

liggitt opened this issue Sep 14, 2016 · 2 comments · Fixed by #40709
Assignees
@deads2k
Labels
area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@liggitt
Copy link
Member

liggitt commented Sep 14, 2016 •
edited
Loading

The Groups field of a SubjectAccessReviewSpec is being serialized as group:

kubernetes/pkg/apis/authorization/v1beta1/types.go

Line 119 in b841a8b

Groups []string `json:"group,omitempty" protobuf:"bytes,4,rep,name=group"`
:

// Groups is the groups you're testing for.
Groups []string `json:"group,omitempty" protobuf:"bytes,4,rep,name=group"`

This is already documented as group for v1beta1, so we can't easily change it now, but should be fixed in the v1 version
@liggitt liggitt mentioned this issue Sep 14, 2016
Merged
@liggitt
Copy link
Member Author

liggitt commented Sep 14, 2016

cc @cjcullen

@k8s-github-robot k8s-github-robot added area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Sep 14, 2016
@deads2k
Copy link
Contributor

deads2k commented Sep 14, 2016

This is already documented as group for v1beta1, so we can't easily change it now, but should be fixed in the v1 version

Right, this was used as the basis for the authz webhook quite some time ago. I agree it should be changed, but that API won't be ready for graduation for a while.

@liggitt liggitt mentioned this issue Feb 2, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Feb 7, 2017
Merge pull request #40709 from liggitt/v1-sar
460f443 
Automatic merge from submit-queue (batch tested with PRs 40971, 41027, 40709, 40903, 39369)

Promote SubjectAccessReview to v1

We have multiple features that depend on this API:

SubjectAccessReview
- [webhook authorization](https://kubernetes.io/docs/admin/authorization/#webhook-mode)
- [kubelet delegated authorization](https://kubernetes.io/docs/admin/kubelet-authentication-authorization/#kubelet-authorization)
- add-on API server delegated authorization

The API has been in use since 1.3 in beta status (v1beta1) with negligible changes:
- Added a status field for reporting errors evaluating access
- A typo was discovered in the SubjectAccessReviewSpec Groups field name

This PR promotes the existing v1beta1 API to v1, with the only change being the typo fix to the groups field. (fixes #32709)

Because the API does not persist data (it is a query/response-style API), there are no data migration concerns.

This positions us to promote the features that depend on this API to stable in 1.7

cc @kubernetes/sig-auth-api-reviews @kubernetes/sig-auth-misc

```release-note
The authorization.k8s.io API group was promoted to v1
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deads2k deads2k

Labels
area/kubectl sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Promote SubjectAccessReview to v1 liggitt/kubernetes
3 participants
@liggitt @deads2k @k8s-github-robot