Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace raw string with const var. #36718

Merged
merged 1 commit into from
Feb 16, 2017
Merged

Replace raw string with const var. #36718

merged 1 commit into from
Feb 16, 2017

Conversation

k82cn
Copy link
Member

@k82cn k82cn commented Nov 13, 2016 •
edited by k8s-oncall

Replace raw string with const string var.

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Nov 13, 2016
@k82cn
Copy link
Member Author

k82cn commented Nov 18, 2016

ping @erictune .

@k82cn
Copy link
Member Author

k82cn commented Dec 21, 2016

@erictune , any comments on this?

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 4, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2017
@k8s-github-robot k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 5, 2017
@k82cn
Copy link
Member Author

k82cn commented Jan 20, 2017

@erictune , any suggestions?

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @lavalamp
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@thockin
Copy link
Member

thockin commented Feb 16, 2017

/lgtm

LGTM from the bulk LGTM tool

@thockin thockin self-assigned this Feb 16, 2017
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2017
@k8s-github-robot k8s-github-robot added the do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. label Feb 16, 2017
@thockin thockin added approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels Feb 16, 2017
@k82cn
Copy link
Member Author

k82cn commented Feb 16, 2017

/release-note-none

@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit df4e69b into kubernetes:master Feb 16, 2017
@k82cn k82cn deleted the filed_err_msg branch February 16, 2017 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@thockin thockin

@erictune erictune

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@k82cn @k8s-github-robot @thockin @smarterclayton @googlebot @erictune @k8s-ci-robot