Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove TPR special casing #36998

Closed
deads2k opened this issue Nov 17, 2016 · 1 comment
Closed

Remove TPR special casing #36998

deads2k opened this issue Nov 17, 2016 · 1 comment
Assignees
@adohe-zz
Labels
area/apiserver area/custom-resources sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@deads2k
Copy link
Contributor

deads2k commented Nov 17, 2016

We should remove IsThirdPartyAPIGroupVersion, AddThirdPartyAPIGroupVersions, and ThirdPartyResourceData. The content needs to have its object meta massaged, but that should mean having its own RESTStorage defined.

ThirdPartyResourceData is being used to carry bits without modification and stomp metadata. That should be changed to runtime.Unstructured because all we care about is moving the bits and setting metadata which is already exposed through api/meta values.
@deads2k deads2k added area/apiserver sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. labels Nov 17, 2016
@deads2k deads2k mentioned this issue Nov 17, 2016
Merged
@bgrant0607 bgrant0607 mentioned this issue Feb 7, 2017
Closed
@smarterclayton
Copy link
Contributor

Handled by CRD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adohe-zz adohe-zz

Labels
area/apiserver area/custom-resources sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@liggitt @smarterclayton @adohe-zz @deads2k