Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing "leaderelection" package when staging to client-go #39117

Closed
hongchaodeng opened this issue Dec 22, 2016 · 2 comments
Closed

Missing "leaderelection" package when staging to client-go #39117

hongchaodeng opened this issue Dec 22, 2016 · 2 comments
Assignees
@caesarxuchao
Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.

Comments

@hongchaodeng
Copy link
Contributor

"pkg/client/leaderelection" depends on a couple other client packages. But it doesn't sit in client-go repo right now.

It's not possible to use "leaderelection" package when using purely "client-go". The staging/copy.sh should also copy "leaderelection" packages.
@hongchaodeng
Copy link
Contributor Author

cc @caesarxuchao

@caesarxuchao caesarxuchao self-assigned this Dec 22, 2016
@caesarxuchao caesarxuchao mentioned this issue Dec 22, 2016
Merged
@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@xiangpengzhao
Copy link
Contributor

/sig api-machinery

@k8s-ci-robot k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jun 22, 2017
@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 22, 2017
k8s-github-robot pushed a commit that referenced this issue Jul 12, 2017
Merge pull request #39173 from caesarxuchao/include-leaderelection
b66be98 
Automatic merge from submit-queue (batch tested with PRs 47232, 48625, 48613, 48567, 39173)

Include leaderelection in client-go; 

Fix #39117
Fix kubernetes/client-go#28

This PR:
* includes the leaderelection to the staging client-go
* to avoid conflict with golang's testing package, renames package /testing to /testutil, and renames cache/testing to cache/testframework

```release-note
client-go now includes the leaderelection package
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caesarxuchao caesarxuchao

Labels
sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@hongchaodeng @caesarxuchao @k8s-github-robot @xiangpengzhao @k8s-ci-robot