Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack/verify-bazel.sh failing with HTTP error 301 #39583

Closed
mtaufen opened this issue Jan 8, 2017 · 10 comments · Fixed by #40875
Closed

hack/verify-bazel.sh failing with HTTP error 301 #39583

mtaufen opened this issue Jan 8, 2017 · 10 comments · Fixed by #40875
Assignees

Comments

@mtaufen
Copy link
Contributor

mtaufen commented Jan 8, 2017

When I run it locally:

$ hack/verify-bazel.sh
# cd .; git clone https://gopkg.in/mikedanese/gazel.v13 /usr/local/google/home/mtaufen/go-tools/src/gopkg.in/mikedanese/gazel.v13
Cloning into '/usr/local/google/home/mtaufen/go-tools/src/gopkg.in/mikedanese/gazel.v13'...
error: RPC failed; HTTP 301 curl 22 The requested URL returned error: 301
fatal: The remote end hung up unexpectedly
package gopkg.in/mikedanese/gazel.v13/gazel: exit status 128
!!! Error in hack/verify-bazel.sh:23
  'go get -u gopkg.in/mikedanese/gazel.v13/gazel' exited with status 1
Call stack:
  1: hack/verify-bazel.sh:23 main(...)
Exiting with status 1

Small test case to induce failure:

$ git clone https://gopkg.in/mikedanese/gazel.v13
Cloning into 'gazel.v13'...
error: RPC failed; HTTP 301 curl 22 The requested URL returned error: 301
fatal: The remote end hung up unexpectedly

I am using git version 2.11.0, if it makes any difference.

@mtaufen
Copy link
Contributor Author

mtaufen commented Jan 8, 2017

Also applies to hack/update-bazel.sh

@mikedanese
Copy link
Member

This is caused by the most recent git upgrade and affects all of our gopkg.in deps but gazel is the one we pull the most. @ixdy @spxtr how do we mitigate this?

@spxtr
Copy link
Contributor

spxtr commented Jan 9, 2017

We could possibly set http.followRedirects in verify/update-gazel, but that feels a bit iffy because it has to be global. Possibly print out the command to fix it in case the go get fails?

@mikedanese
Copy link
Member

Source code for gopkg.in is here https://github.com/niemeyer/gopkg . There doesn't seem to be an open issue for this.

@mikedanese
Copy link
Member

mikedanese commented Jan 9, 2017

I filed niemeyer/gopkg#50

@spxtr
Copy link
Contributor

spxtr commented Jan 9, 2017

@ixdy says git config --global http.https://gopkg.in.followRedirects true

@niemeyer
Copy link

Sorry for the trouble. We'll change gopkg.in a bit to ensure the manual configuration is not necessary.

@nikhiljindal
Copy link
Contributor

@niemeyer Was this fixed in gopkg.in?

k8s-github-robot pushed a commit that referenced this issue Feb 3, 2017
Automatic merge from submit-queue (batch tested with PRs 40884, 40809, 40845, 40866, 40875)

update repo local config to allow redirects from gopkg.in

closes #39583
@niemeyer
Copy link

No need to change the configuration anymore. We've changed gopkg.in itself to support the new git quirks.

@mikedanese
Copy link
Member

@niemeyer thanks for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants