dnsprovider: Add upsert #39957
Merged
dnsprovider: Add upsert #39957
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
k8s-github-robot
added
size/M
|
Quite right, I do quinton. Sorry to disparage the very worthy 39085 :-) |
ghost
mentioned this pull request
ghost
approved these changes
Jan 25, 2017
| @@ -68,6 +68,10 @@ type ResourceRecordChangeset interface { | |||
| // Remove adds the removal of a ResourceRecordSet in the Zone to the changeset | |||
| // The supplied ResourceRecordSet must match one of the existing recordsets (obtained via List()) exactly. | |||
| Remove(ResourceRecordSet) ResourceRecordChangeset | |||
| // Upsert adds an "create or update" operation for the ResourceRecordSet in the Zone to the changeset | |||
| // Note: the implementation may translate this into Add & Remove operations. If you have the pre-image, | |||
|
/lgtm @justinsb, my apologies for the delay on this one. |
k8s-ci-robot
added
the
lgtm
ghost
added
the
approved
k8s-github-robot
added
the
needs-rebase
ghost
mentioned this pull request
Although Google Cloud DNS requires strict add & remove calls, most dnsproviders actually support upsert, and an add & remove is much more expensive (primarily because of the need to fetch the pre-image). Add support for 'upsert' operations, which don't require the pre-image, and simply overwrite the existing record. This is much cheaper on Amazon Route53, for example.
justinsb
force-pushed
the
dnsprovider_upsert
branch
from
adbda2e
to
662ba86
Compare
k8s-github-robot
removed
lgtm
|
Rebased and fixed the comment per your suggestion @quinton-hoole - thanks! |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
The integration test failure seems to be completely unrelated to this PR. |
ghost
mentioned this pull request
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: justinsb, nikhiljindal Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
mtaufen
pushed a commit
to mtaufen/kubernetes
that referenced
this pull request
Feb 7, 2017
Automatic merge from submit-queue dnsprovider: Add upsert Although Google Cloud DNS requires strict add & remove calls, most dnsproviders actually support upsert, and an add & remove is much more expensive (primarily because of the need to fetch the pre-image). Add support for 'upsert' operations, which don't require the pre-image, and simply overwrite the existing record. This is much cheaper on Amazon Route53, for example. ```release-note NONE ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although Google Cloud DNS requires strict add & remove calls, most
dnsproviders actually support upsert, and an add & remove is much more
expensive (primarily because of the need to fetch the pre-image).
Add support for 'upsert' operations, which don't require the pre-image,
and simply overwrite the existing record. This is much cheaper on
Amazon Route53, for example.