Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a default StorageClass for Azure #40071

Closed
jsafrane opened this issue Jan 18, 2017 · 3 comments
Closed

Create a default StorageClass for Azure #40071

jsafrane opened this issue Jan 18, 2017 · 3 comments
Assignees
@colemickens @brendandburns
Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage.

Comments

@jsafrane
Copy link
Member

We'd like to deprecate alpha provisioning in 1.6. In order to make current deployments working after upgrade to 1.6 we need to deploy a default StorageClass as part of installation/upgrade on Azure so it will automatically provision volumes for PVCs marked with annotation volume.alpha.kubernetes.io/storage-class - the annotation will be ignored and default storage class must provision the volume instead.

On GCE and AWS, we use addon manager to install the default storage class, see https://github.com/kubernetes/kubernetes/tree/master/cluster/addons/storage-class. Note that some extra code is probably needed to actually put the storage class into addons directory during installation, e.g. https://github.com/kubernetes/kubernetes/blob/master/cluster/gce/container-linux/configure-helper.sh#L1129 for manual script-based installation on GCE or https://github.com/kubernetes/kubernetes/blob/master/cluster/saltbase/salt/kube-addons/init.sls#L181 for salt-based installation.

Please make sure that:

  • A default StorageClass is deployed during "default" installation.
    • It would be nice if admin could turn this off during installation (e.g. as export ENABLE_DEFAULT_STORAGE_CLASS=false on GCE)
  • If any additional manual steps are needed to deploy the default storage class make sure they're documented in appropriate installation guide.
@jsafrane jsafrane added area/platform/azure sig/storage Categorizes an issue or PR as relevant to SIG Storage. labels Jan 18, 2017
@jsafrane
Copy link
Member Author

Assigning to random Microsoft personnel for faster routing to proper person.

This was referenced Jan 18, 2017
Merged
Closed
@colemickens colemickens mentioned this issue Feb 3, 2017
Closed
@brendandburns brendandburns mentioned this issue Feb 9, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Feb 12, 2017
Merge pull request #41182 from brendandburns/storage
19ddde6 
Automatic merge from submit-queue (batch tested with PRs 41182, 41290)

Add a default storage class for Azure Disk

Part of #40071

@jsafrane @colemickens @codablock @rootfs
@brendandburns
Copy link
Contributor

@jsafrane I believe this is fixed, correct? If so, I will close it...

@jsafrane
Copy link
Member Author

Yes, it's fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@colemickens colemickens

@brendandburns brendandburns

Labels
sig/storage Categorizes an issue or PR as relevant to SIG Storage.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colemickens @jsafrane @brendandburns