Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add deads2k to registry package owners #41009

Merged
merged 1 commit into from
Feb 6, 2017
Merged

add deads2k to registry package owners #41009

merged 1 commit into from
Feb 6, 2017

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Feb 6, 2017

I established the package layout and wrote a lot of the non-boilerplate code in this package.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@deads2k
Copy link
Contributor Author

deads2k commented Feb 6, 2017

/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Feb 6, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. retest-not-required-docs-only labels Feb 6, 2017
@luxas luxas assigned lavalamp, smarterclayton and wojtek-t and unassigned luxas Feb 6, 2017
@luxas
Copy link
Member

luxas commented Feb 6, 2017

Oh well, I'm not the one who should make this call.

LGTM, but assigning @smarterclayton @lavalamp @wojtek-t

@k8s-bot kops aws e2e test this

@smarterclayton
Copy link
Contributor

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: deads2k, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 8867327 into kubernetes:master Feb 6, 2017
@deads2k deads2k deleted the owners-06-registry branch March 7, 2017 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@lavalamp lavalamp

@smarterclayton smarterclayton

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@deads2k @k8s-reviewable @luxas @smarterclayton @k8s-github-robot @lavalamp @wojtek-t @k8s-ci-robot