Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Federation][kubefed] Flag cleanup #41333

Closed
irfanurrehman opened this issue Feb 13, 2017 · 3 comments
Closed

[Federation][kubefed] Flag cleanup #41333

irfanurrehman opened this issue Feb 13, 2017 · 3 comments

Comments

@irfanurrehman
Copy link
Contributor

Kubefed init recently added --apiserver-arg-overrides and --controllermanager-arg-overrides, which can now be used to pass arguments to federation apiserver and controller manager during initial deployment.
There are some flags which were used as explicit flags, which should be removed and these new ones should be used instead.
@irfanurrehman irfanurrehman mentioned this issue Feb 13, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue Mar 1, 2017
Merge pull request #41335 from irfanurrehman/kubefed-flag-cleanup
aaaa7e4 
Automatic merge from submit-queue (batch tested with PRs 42200, 39535, 41708, 41487, 41335)

[Federation][Kubefed] Flag cleanup

This PR is for the issue #41333

**Special notes for your reviewer**:
@marun @madhusudancs 


**Release note**:

```
Kubefed init unlearned the following flags:
--storage-backend

Users should instead use the following flag to pass additional arguments:
--apiserver-arg-overrides to api server
```
@k8s-github-robot
Copy link

@irfanurrehman There are no sig labels on this issue. Please add a sig label by:
(1) mentioning a sig: @kubernetes/sig-<team-name>-misc
(2) specifying the label manually: /sig <label>

Note: method (1) will trigger a notification to the team. You can find the team list here.

@k8s-github-robot k8s-github-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label May 31, 2017
@0xmichalis
Copy link
Contributor

/sig federation

@k8s-github-robot k8s-github-robot removed the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Jun 20, 2017
@irfanurrehman
Copy link
Contributor Author

Apologies for not following this up earlier.
The PR relating this issue was merged quite some time back.
Closing this issue as fixed, thus.

perotinus pushed a commit to kubernetes-retired/cluster-registry that referenced this issue Sep 2, 2017
Merge pull request #41335 from irfanurrehman/kubefed-flag-cleanup
c90e283 
Automatic merge from submit-queue (batch tested with PRs 42200, 39535, 41708, 41487, 41335)

[Federation][Kubefed] Flag cleanup

This PR is for the issue kubernetes/kubernetes#41333

**Special notes for your reviewer**:
@marun @madhusudancs 


**Release note**:

```
Kubefed init unlearned the following flags:
--storage-backend

Users should instead use the following flag to pass additional arguments:
--apiserver-arg-overrides to api server
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@0xmichalis @irfanurrehman @k8s-github-robot @k8s-ci-robot