Adds kube-public to the whitelist to not be deleted for e2e tests #41420
Conversation
jbeda
added
the
release-note-none
k8s-ci-robot
added
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED The following people have approved this PR: jbeda Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
k8s-github-robot
added
the
size/XS
|
This change is |
test/e2e/e2e.go
Outdated
| @@ -111,7 +111,13 @@ var _ = ginkgo.SynchronizedBeforeSuite(func() []byte { | |||
| // Delete any namespaces except default and kube-system. This ensures no | |||
| // lingering resources are left over from a previous test run. | |||
| if framework.TestContext.CleanStart { | |||
| deleted, err := framework.DeleteNamespaces(c, nil /* deleteFilter */, []string{metav1.NamespaceSystem, metav1.NamespaceDefault, federationapi.FederationNamespaceSystem}) | |||
| deleted, err := framework.DeleteNamespaces(c, nil, /* deleteFilter */ | |||
There was a problem hiding this comment.
Comment above is out of date
jbeda
force-pushed
the
add-public-to-e2e
branch
from
54ce806
to
9375294
Compare
k8s-github-robot
added
size/S
|
@sttts PTAL -- comment fixed up. |
|
/lgtm |
|
@sttts: you can't LGTM a PR unless you are an assignee. In response to this comment:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
Automatic merge from submit-queue |
We added the
kube-publicnamespace but didn't add it to a whitelist of namespaces to not delete as part of e2e cleanup.