Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run kubelet in test-cmd.sh #41843

Merged
merged 1 commit into from
Feb 25, 2017
Merged

Do not run kubelet in test-cmd.sh #41843

merged 1 commit into from
Feb 25, 2017

Conversation

yujuhong
Copy link
Contributor

@yujuhong yujuhong commented Feb 21, 2017 •
edited

The tests are intended to test only kubectl commands and do not
require kubelet.

This fixes #41834

/cc @Random-Liu @dchen1107 @nikhiljindal

@yujuhong
Do not run kubelet in test-cmd.sh
84d46cc 
The tests are intended to test only `kubectl` commands and do not
require kubelet.
@yujuhong yujuhong added the sig/cli Categorizes an issue or PR as relevant to SIG CLI. label Feb 21, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 21, 2017
@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Feb 21, 2017
@yujuhong
Copy link
Contributor Author

@kubernetes/sig-cli-misc

@yujuhong yujuhong added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 21, 2017
@yujuhong yujuhong assigned pwittrock and unassigned zmerlynn Feb 21, 2017
@k8s-reviewable
Copy link

This change is Reviewable

This was referenced Feb 21, 2017
Closed
Closed
@smarterclayton
Copy link
Contributor

smarterclayton commented Feb 21, 2017 •
edited

/approve

Was the original intent

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 21, 2017
@yujuhong
Copy link
Contributor Author

Was the original intent

@smarterclayton wanna review it too? :) The PR only removes code.

@dchen1107
Copy link
Member

This change looks good to me.

@nikhiljindal
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

@nikhiljindal: you can't LGTM a PR unless you are an assignee.

In response to this comment:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nikhiljindal nikhiljindal self-assigned this Feb 21, 2017
@nikhiljindal
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2017
@yujuhong yujuhong closed this Feb 21, 2017
@yujuhong yujuhong reopened this Feb 21, 2017
@yujuhong
Copy link
Contributor Author

@k8s-bot cvm gke e2e test this
@k8s-bot gci gke e2e test this
@k8s-bot unit test this
@k8s-bot kubemark e2e test this
@k8s-bot gci gce e2e test this
@k8s-bot kops aws e2e test this
@k8s-bot node e2e test this

@yujuhong
Copy link
Contributor Author

@k8s-bot gci gce e2e test this
@k8s-bot cvm gke e2e test this

@yujuhong
Copy link
Contributor Author

@k8s-bot kubemark e2e test this
@k8s-bot gce etcd3 e2e test this

@yujuhong yujuhong added this to the v1.6 milestone Feb 24, 2017
@nikhiljindal
Copy link
Contributor

@k8s-bot kops aws e2e test this

@pwittrock
Copy link
Member

@k8s-bot non-cri e2e test this

@pwittrock
Copy link
Member

@k8s-bot kops aws e2e test this

@pwittrock
Copy link
Member

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: nikhiljindal, pwittrock, smarterclayton, yujuhong

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 40665, 41094, 41351, 41721, 41843)

@k8s-github-robot k8s-github-robot merged commit e40b55f into kubernetes:master Feb 25, 2017
@yujuhong yujuhong deleted the do-not-run-kubelet branch March 13, 2017 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pwittrock pwittrock

@nikhiljindal nikhiljindal

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

make test-cmd failing locally with permission error for dockershim
9 participants
@yujuhong @k8s-reviewable @smarterclayton @dchen1107 @nikhiljindal @k8s-ci-robot @pwittrock @k8s-github-robot @zmerlynn