Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

controller: add approvers for rc/rs #41876

Merged
merged 1 commit into from
Feb 24, 2017
Merged

controller: add approvers for rc/rs #41876

merged 1 commit into from
Feb 24, 2017

Conversation

0xmichalis
Copy link
Contributor

@0xmichalis 0xmichalis commented Feb 22, 2017 •
edited

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 22, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-label-needed labels Feb 22, 2017
@0xmichalis 0xmichalis added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 22, 2017
@caesarxuchao
Copy link
Member

lgtm. We need an approver listed in pkg/controller/OWNERS to approve the change. @derekwaynecarr could you help?

@caesarxuchao
Copy link
Member

cc @grodrigues3 the merge-bot's message has a bug, it should suggest us to find an approver for this PR from pkg/controller/OWNERS

@grodrigues3 grodrigues3 mentioned this pull request Feb 22, 2017
Closed
@0xmichalis
Copy link
Contributor Author

@k8s-bot tell me a joke

@0xmichalis
Copy link
Contributor Author

@janetkuo ptal

@0xmichalis
Copy link
Contributor Author

@k8s-bot gce etcd3 e2e test this
@k8s-bot gci gce e2e test this

@0xmichalis 0xmichalis added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 24, 2017
@janetkuo
Copy link
Member

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: janetkuo, kargakis

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 24, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 46b20ac into kubernetes:master Feb 24, 2017
@0xmichalis 0xmichalis deleted the add-approvers-in-rc-rs-controllers branch February 24, 2017 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janetkuo janetkuo janetkuo approved these changes

Assignees

@caesarxuchao caesarxuchao

@janetkuo janetkuo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@0xmichalis @k8s-reviewable @caesarxuchao @janetkuo @k8s-github-robot @k8s-ci-robot