Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert storage v1 #42114

Merged
merged 2 commits into from
Feb 26, 2017
Merged

Revert storage v1 #42114

merged 2 commits into from
Feb 26, 2017

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Feb 26, 2017

If we're unable to get storage.k8s.io/v1 enabled in GKE, we should revert #40088 to get the queue running again.

@liggitt
Revert "Merge pull request kubernetes#42105 from ncdc/use-storage-v1b…
ce79526 
…eta1-in-e2e"

This reverts commit 59735fb, reversing
changes made to 197bd53.
@liggitt
Revert "Merge pull request kubernetes#40088 from jsafrane/storage-ga-v1"
41c88e0 
This reverts commit 5984607, reversing
changes made to 067f92e.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 26, 2017
@k8s-github-robot k8s-github-robot added kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/new-api size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@liggitt liggitt mentioned this pull request Feb 26, 2017
Merged
@liggitt
Copy link
Member Author

liggitt commented Feb 26, 2017

cc @jsafrane @ncdc @k8s-oncall

@liggitt liggitt added priority/P0 release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Feb 26, 2017
@liggitt
Copy link
Member Author

liggitt commented Feb 26, 2017 •
edited

cc @thockin @saad-ali @msau42

@liggitt liggitt assigned thockin, saad-ali and msau42 and unassigned luxas Feb 26, 2017
@liggitt liggitt added this to the v1.6 milestone Feb 26, 2017
@msau42
Copy link
Member

msau42 commented Feb 26, 2017

I don't think it's going to get enabled in the next few hours so go ahead and revert it if it's blocking the entire submit queue.

@msau42
Copy link
Member

msau42 commented Feb 26, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

The following people have approved this PR: liggitt, msau42

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @smarterclayton
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@wojtek-t
Copy link
Member

This is supposed to fix merge-queue. So merging manually.

@wojtek-t wojtek-t merged commit 2a29da1 into kubernetes:master Feb 26, 2017
@liggitt liggitt deleted the revert-storage-v1 branch February 26, 2017 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

@saad-ali saad-ali

@msau42 msau42

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@liggitt @k8s-reviewable @msau42 @k8s-github-robot @wojtek-t @luxas @thockin @saad-ali @k8s-ci-robot