Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to k8s json to avoid number decoding issue #42489

Merged
merged 1 commit into from
Mar 7, 2017
Merged

switch to k8s json to avoid number decoding issue #42489

merged 1 commit into from
Mar 7, 2017

Conversation

mengqiy
Copy link
Member

@mengqiy mengqiy commented Mar 3, 2017 •
edited

Fixes #42488
Fixes #42282

use "k8s.io/apimachinery/pkg/util/json" to avoid number conversion issues

@liggitt Same reason as #40666 (review)

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. labels Mar 3, 2017
@liggitt
Copy link
Member

liggitt commented Mar 3, 2017 •
edited

please add unit tests that reproduce the issues to ensure this doesn't regress

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 3, 2017
@mengqiy
Copy link
Member Author

mengqiy commented Mar 3, 2017

Test added. PTAL

@soltysh
Copy link
Contributor

soltysh commented Mar 3, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 3, 2017
@liggitt
Copy link
Member

liggitt commented Mar 3, 2017

LGTM

@liggitt liggitt added the kind/bug Categorizes issue or PR as related to a bug. label Mar 3, 2017
@liggitt liggitt added this to the v1.6 milestone Mar 3, 2017
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 3, 2017 •
edited

@ymqytw: The following test(s) failed:

Test name Commit Details Rerun command
Jenkins GCI GKE smoke e2e ef364ca3983801b7867bfa1b141734c535896028 link @k8s-bot gci gke e2e test this
Jenkins GKE smoke e2e ef364ca3983801b7867bfa1b141734c535896028 link @k8s-bot cvm gke e2e test this

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@mengqiy
Copy link
Member Author

mengqiy commented Mar 3, 2017

@k8s-bot non-cri e2e test this
@k8s-bot gce etcd3 e2e test this

@mengqiy
Copy link
Member Author

mengqiy commented Mar 3, 2017

@lavalamp Need approval.

@mengqiy mengqiy mentioned this pull request Mar 6, 2017
Closed
@mengqiy
Copy link
Member Author

mengqiy commented Mar 7, 2017

@lavalamp @smarterclayton Mind take a look?

@smarterclayton
Copy link
Contributor

/approve

Significant bug, was a regression, low risk given the test and previous behavior.

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

The following people have approved this PR: smarterclayton, soltysh, ymqytw

Needs approval from an approver in each of these OWNERS Files:

We suggest the following people:
cc @thockin
You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 7, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 4c4c9e4 into kubernetes:master Mar 7, 2017
@mengqiy mengqiy deleted the switch_json branch March 7, 2017 04:04
@mengqiy mengqiy mentioned this pull request Mar 10, 2017
Closed
@mengqiy mengqiy mentioned this pull request Mar 17, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mengqiy @k8s-reviewable @liggitt @soltysh @k8s-ci-robot @smarterclayton @k8s-github-robot