Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force create symlinks. #43177

Merged
merged 1 commit into from
Mar 16, 2017
Merged

Force create symlinks. #43177

merged 1 commit into from
Mar 16, 2017

Conversation

mml
Copy link
Contributor

@mml mml commented Mar 15, 2017

Followup from #43070. Fixes #42660 in a way that does not break etcd upgrades.

@mml mml added this to the v1.6 milestone Mar 15, 2017
@mml mml added priority/P3 release-note-none Denotes a PR that doesn't merit a release note. labels Mar 15, 2017
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 15, 2017
@k8s-github-robot k8s-github-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 15, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@mwielgus
Copy link
Contributor

We have the same problems with cluster autoscaler tests on GKE. GKE restarts master to enable CA and then the master stops to initialize properly.

@mwielgus
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2017
@jszczepkowski
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jszczepkowski, mml, mwielgus

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 16, 2017
@mwielgus mwielgus self-requested a review March 16, 2017 13:15
@k8s-github-robot
Copy link

Automatic merge from submit-queue

@k8s-github-robot k8s-github-robot merged commit 47bea96 into kubernetes:master Mar 16, 2017
@mikedanese mikedanese mentioned this pull request Mar 24, 2017
Merged
k8s-github-robot pushed a commit that referenced this pull request Mar 27, 2017
Merge pull request #43636 from mikedanese/automated-cherry-pick-of-#4…
929a122 
…3177-#43070-#43529-release-1.5

Automatic merge from submit-queue

Automated cherry pick of #43177 #43070 #43529 release 1.5

fixes downgrades from 1.5.6 -> 1.5.5 and below
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwielgus mwielgus Awaiting requested review from mwielgus

Assignees

@mikedanese mikedanese

@mwielgus mwielgus

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.6
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mml @k8s-reviewable @mwielgus @jszczepkowski @k8s-github-robot @mikedanese @k8s-ci-robot