Retry kubectl test replace on conflict #43192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
liggitt
added
kind/failing-test
|
cc @kubernetes/sig-cli-bugs @kubernetes/sig-cli-pr-reviews |
|
This change is |
|
It seems it ddidn't "compile": |
liggitt
force-pushed
the
kubectl-test-retry
branch
from
dab7e31
to
9cd791e
Compare
|
fixed |
0xmichalis
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, liggitt
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
|
Automatic merge from submit-queue |
dims
pushed a commit
to dims/kubernetes
that referenced
this pull request
Mar 22, 2017
Automatic merge from submit-queue (batch tested with PRs 43513, 43499) Make kubectl replace unconditional second attempt at kubernetes#43192 rather than a retry, make the replace unconditional, which works reliably
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since kubectl is doing a resource-version-constrained replace, it is subject to conflicts on a contentious resource (like a node managed by the node controller)
Fixes #41892 (the specific flake, not the watch cache issue)