Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump(github.com/onsi/ginkgo):v1.2.0-94-g5ca1211 #43273

Merged
merged 1 commit into from
Apr 10, 2017
Merged

bump(github.com/onsi/ginkgo):v1.2.0-94-g5ca1211 #43273

merged 1 commit into from
Apr 10, 2017

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Mar 17, 2017 •
edited

Picks up parallel execution improvements in Ginkgo that distribute jobs more evenly with parallel runs. Opened after observing long tail runs in OpenShift - testing there showed a much more compact run in terms of CPU onsi/ginkgo#333

We'll need some soak time to be sure this has no issues.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 17, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2017
@k8s-github-robot k8s-github-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. release-note-label-needed labels Mar 17, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@smarterclayton smarterclayton added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 17, 2017
@smarterclayton
Copy link
Contributor Author

Totally unscientific, but in the GCE e2e runs they normally take between 850-900s, and this first run finished in 799. Will run a few more times to get some better variance measurements. We may be able to bump parallelism too.

@smarterclayton
Copy link
Contributor Author

@k8s-bot gce e2e test this

1 similar comment
@smarterclayton
Copy link
Contributor Author

@k8s-bot gce e2e test this

@thockin thockin added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2017
@thockin
Copy link
Member

thockin commented Mar 17, 2017

@k8s-bot verify test this

@smarterclayton
Copy link
Contributor Author

@k8s-bot gce e2e test this

@smarterclayton smarterclayton force-pushed the parallel_ginkgo branch 2 times, most recently from 969872c to 05ff408 Compare March 19, 2017 23:16
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 19, 2017
@smarterclayton
Copy link
Contributor Author

Looks like this improves GCE e2e run by 4-5 minutes on average.

@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 23, 2017
@smarterclayton
Copy link
Contributor Author

Readding label

@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2017
@fejta fejta removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 25, 2017
@onsi onsi mentioned this pull request Mar 29, 2017
Closed
@k8s-github-robot k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 30, 2017
@smarterclayton
bump(github.com/onsi/ginkgo):v1.2.0-94-g5ca1211
f654505 
Picks up parallel execution improvements in Ginkgo that distribute jobs
more evenly with parallel
@k8s-github-robot k8s-github-robot removed lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Apr 9, 2017
@smarterclayton smarterclayton added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 9, 2017
@smarterclayton
Copy link
Contributor Author

@k8s-bot bazel build this

@smarterclayton
Copy link
Contributor Author

@k8s-bot cvm gce e2e test this

@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43273, 44287, 44281)

@k8s-github-robot k8s-github-robot merged commit 9e929c6 into kubernetes:master Apr 10, 2017
@smarterclayton
Copy link
Contributor Author

https://k8s-gubernator.appspot.com/builds/kubernetes-jenkins/logs/ci-kubernetes-e2e-gci-gce/

Brought variability from 25-34 minutes down to a much tighter 24-26 minutes. I think this is a success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thockin thockin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@smarterclayton @k8s-github-robot @k8s-reviewable @thockin @fejta @k8s-ci-robot