Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix some typos in apiserver #43373

Merged
merged 1 commit into from
Apr 7, 2017
Merged

fix some typos in apiserver #43373

merged 1 commit into from
Apr 7, 2017

Conversation

supereagle
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes:

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

Hi @supereagle. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Mar 20, 2017
@supereagle
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Mar 20, 2017
@k82cn
Copy link
Member

k82cn commented Mar 20, 2017

@k8s-bot ok to test

@cblecker
Copy link
Member

Looks like an unrelated flake.
@k8s-bot unit test this

@cblecker
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 20, 2017
@cblecker
Copy link
Member

@k8s-bot gce etcd3 e2e test this

@krousey
Copy link
Contributor

krousey commented Mar 27, 2017

/approve

@cblecker
Copy link
Member

/assign @smarterclayton
So it shows up in his PR dashboard as pending approval :)

@supereagle
Copy link
Contributor Author

@smarterclayton This PR needs your approval :). Thanks.

@cblecker
Copy link
Member

cblecker commented Apr 6, 2017

@k8s-bot verify test this

smarterclayton
smarterclayton reviewed Apr 6, 2017
View reviewed changes
staging/src/k8s.io/apiserver/pkg/endpoints/installer.go Outdated
Path string // The path of the action
Params []*restful.Parameter // List of parameters associated with the action.
Namer handlers.ScopeNamer
AllNamespaces bool // true iff the action is namespaced but works on aggregate result for all namespaces
AllNamespaces bool // true if the action is namespaced but works on aggregate result for all namespaces
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional - 'if and only if'

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I will revert this.

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2017
@k82cn
Copy link
Member

k82cn commented Apr 7, 2017

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2017
@supereagle
Copy link
Contributor Author

@smarterclayton Have updated.

@smarterclayton
Copy link
Contributor

/lgtm

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cblecker, k82cn, krousey, smarterclayton, supereagle

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 43373, 41780, 44141, 43914, 44180)

@k8s-github-robot k8s-github-robot merged commit 9095c78 into kubernetes:master Apr 7, 2017
@supereagle supereagle deleted the fix-typos branch April 7, 2017 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

Assignees

@krousey krousey

@smarterclayton smarterclayton

@cblecker cblecker

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@supereagle @k8s-reviewable @k8s-ci-robot @k82cn @cblecker @krousey @smarterclayton @k8s-github-robot