only log stacks on server errors #43377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
approved
k8s-github-robot
added
size/XS
|
This change is |
|
LGTM, thanks for fixing this @deads2k |
deads2k
force-pushed
the
server-09-logging
branch
from
c19542f
to
c4d492b
Compare
k8s-github-robot
added
size/S
|
👍 |
deads2k
force-pushed
the
server-09-logging
branch
from
c4d492b
to
fe3a06e
Compare
|
@ncdc what ridiculous change? |
k8s-github-robot
added
size/M
|
/assign /lgtm |
k8s-github-robot
added
the
needs-rebase
deads2k
force-pushed
the
server-09-logging
branch
from
fe3a06e
to
b73cddb
Compare
k8s-github-robot
removed
the
needs-rebase
deads2k
added
the
lgtm
k8s-github-robot
added
the
do-not-merge
deads2k
added
release-note-none
|
Automatic merge from submit-queue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack traces on http logging statements can be useful, but you usually only need them for server errors not for things like redirects or even client errors since the server won't be fixing those.
This tightens the "log stack" behavior to only happen for server errors. Messages will still be logged, but the automatic stacks will only come out for server errors.
@enj @mfojtik @smarterclayton
@kubernetes/sig-api-machinery-misc