unit test for kubectl config set #43517
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This change is |
|
Hi @zjj2wry. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-github-robot
added
size/M
zjj2wry
force-pushed
the
007
branch
2 times, most recently
from
ce0bb63
to
8e6981c
Compare
k8s-github-robot
added
size/L
pkg/kubectl/cmd/config/set_test.go
Outdated
| } | ||
| } | ||
| if len(test.args) == 2 { | ||
| if test.args[1] != config.CurrentContext { |
There was a problem hiding this comment.
This means that the test struct only works for testing set against the current context right? That's ok, but its more restrictive than the name suggests. How about comparing against the expectedConfig instead?
There was a problem hiding this comment.
yes,i start want compare config , but real config will initialize some nil map , and LocationOfOrigin etc. so my expectConfig can not initialize completely in testcases.
There was a problem hiding this comment.
yes,i start want compare config , but real config will initialize some nil map , and LocationOfOrigin etc. so my expectConfig can not initialize completely in testcases.
Before the comparison, you could clear the LocationOfOrigin and you could initialize the maps in your expectConfig.
There was a problem hiding this comment.
@deads2k sorry to reply late. i will update like you say. think you very much
grodrigues3
added
the
needs-ok-to-test
k8s-github-robot
added
size/M
k8s-ci-robot
removed
the
needs-ok-to-test
|
@zjj2wry: you can't request testing unless you are a kubernetes member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/lgtm |
|
@deads2k: you can only set release notes if you are the author or an assignee. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-ci-robot
added
the
lgtm
|
@k8s-bot ok to test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, zjj2wry
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
approved
deads2k
added
release-note-none
k8s-github-robot
added
the
approved
|
@k8s-bot verify test this |
|
@zjj2wry: you can't request testing unless you are a kubernetes member. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@k8s-bot verify test this |
|
@zjj2wry: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Automatic merge from submit-queue |
What this PR does / why we need it:
unit test for kubectl config set
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged): fixes #Special notes for your reviewer:
think you
Release note: