remove go-restful from namer for rest handling #43767
Merged
+256
−288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XL
|
This change is |
|
|
@k8s-bot non-cri e2e test this |
sttts
reviewed
Mar 29, 2017
| @@ -746,7 +757,7 @@ func TestNotFound(t *testing.T) { | |||
| "groupless root DELETE with extra segment": {"DELETE", "/" + grouplessPrefix + "/" + grouplessGroupVersion.Version + "/simpleroots/bar/baz", http.StatusNotFound}, | |||
| "groupless root PUT without extra segment": {"PUT", "/" + grouplessPrefix + "/" + grouplessGroupVersion.Version + "/simpleroots", http.StatusMethodNotAllowed}, | |||
| "groupless root PUT with extra segment": {"PUT", "/" + grouplessPrefix + "/" + grouplessGroupVersion.Version + "/simpleroots/bar/baz", http.StatusNotFound}, | |||
| "groupless root watch missing storage": {"GET", "/" + grouplessPrefix + "/" + grouplessGroupVersion.Version + "/watch/", http.StatusNotFound}, | |||
| "groupless root watch missing storage": {"GET", "/" + grouplessPrefix + "/" + grouplessGroupVersion.Version + "/watch/", http.StatusInternalServerError}, | |||
There was a problem hiding this comment.
Why do these change?
This used to test the cases without the "normal" handler chain. Once you add a requestInfoResolver into the chain, it fails on these URLs because they aren't well formed. The same thing would happen in our real chain.
sttts
reviewed
Mar 29, 2017
| @@ -1169,6 +1180,7 @@ func TestNonEmptyList(t *testing.T) { | |||
| if err != nil { | |||
| t.Fatalf("unexpected error: %v", err) | |||
| } | |||
| t.Log(body) | |||
There was a problem hiding this comment.
debug output
Super useful when the test goes poorly.
sttts
reviewed
Mar 29, 2017
| objNamespace, objName, err := namer.ObjectName(obj) | ||
| if err != nil { | ||
| return errors.NewBadRequest(fmt.Sprintf( | ||
| "the name of the object (%s based on URL) was undeterminable %v", name, err)) |
deads2k
force-pushed
the
server-13-namer
branch
from
c1f0f69
to
da27957
Compare
|
Nit updated. Other comments? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: deads2k, sttts
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
k8s-github-robot
added
the
do-not-merge
deads2k
added
approved
|
vendor/build again. marking |
|
@k8s-bot test this |
Merged
|
bot can be up to 10 minutes behind, but I'm betting this is more than 10 minutes... |
|
@k8s-bot test this [submit-queue is verifying that this PR is safe to merge] |
|
Automatic merge from submit-queue |
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 10, 2017
Automatic merge from submit-queue (batch tested with PRs 43273, 44287, 44281) Remove ObjectMetaFor Builds on #43767 The second commit removes `ObjectMetaFor`. This was debt we left around after we created the interfaces. Fixing this makes it possible to start running `Unstructured` through generic storage. @kubernetes/sig-api-machinery-pr-reviews @smarterclayton @lavalamp
akhilerm
pushed a commit
to akhilerm/apimachinery
that referenced
this pull request
Sep 20, 2022
Automatic merge from submit-queue (batch tested with PRs 43273, 44287, 44281) Remove ObjectMetaFor Builds on kubernetes/kubernetes#43767 The second commit removes `ObjectMetaFor`. This was debt we left around after we created the interfaces. Fixing this makes it possible to start running `Unstructured` through generic storage. @kubernetes/sig-api-machinery-pr-reviews @smarterclayton @lavalamp Kubernetes-commit: d4eaf0b6801900d2b2f80036e267a1d3d86fd3a8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our RESTHandler code is currently tightly coupled to go-restful, but there's no reason for this coupling. It makes integrations that want API handling (decode, sanity check, admission, verb handling), but don't need the REST installer flow impractical. I know of two layers now: metrics and TPR.
This starts the process of unwinding by switching the
ScopeNamer(used for request identification and selflinks) to use the standard http library along with theRequestInfowe place in the context for authorization and any other interested layer.@kubernetes/sig-api-machinery-misc @smarterclayton @ncdc @sttts