-
Notifications
You must be signed in to change notification settings - Fork 39.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Federation] Daemonset with finalizer not always getting deleted #43828
Comments
Discussed this with Nikhil earlier today. The buggy behavior is a result of handling removal of 2 or more annotations. In this case, the daemonset and namespace controllers both try to remove orphan and delete-from finalizers but the code isn't written to expect separate updates. Seen again here today: https://k8s-gubernator.appspot.com/build/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-federation/2570 Marking P0. With the fix in, we should be above 90% in no-flakes. |
Sent #44084 to fix this |
Automatic merge from submit-queue (batch tested with PRs 44084, 42964) Removing both finalizers in federation controllers in a single update Fixes #43828 There is a bug right now where the controller fails to delete the object if one finalizer is removed and the second isnt. This updates the code so that both the finalizers are removed in a single API call. Kept the code changes minimum to enable cherrypick in 1.6.x cc @csbell @kubernetes/sig-federation-bugs
…y-pick-of-#44084-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#44084 Cherry pick of kubernetes#44084 on release-1.6. kubernetes#44084: Removing both finalizers in federation controller in a ```release-note Fix for [failure to delete federation controllers with finalizers](kubernetes#43828). ```
Automatic merge from submit-queue (batch tested with PRs 44084, 42964) Removing both finalizers in federation controllers in a single update Fixes kubernetes/kubernetes#43828 There is a bug right now where the controller fails to delete the object if one finalizer is removed and the second isnt. This updates the code so that both the finalizers are removed in a single API call. Kept the code changes minimum to enable cherrypick in 1.6.x cc @csbell @kubernetes/sig-federation-bugs
From CI failure here: https://storage.googleapis.com/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-federation/2458/build-log.txt
Upon deleting with orphan=true, the finalizer Update() fails and the next time around the federated object is never deleted. This is flaky.
Relevant bits:
The text was updated successfully, but these errors were encountered: