Automated cherry pick of #44053 #44313 #44315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
k8s-github-robot
added
approved
k8s-ci-robot
added
the
cncf-cla: yes
|
This brings in the rest of #44053 |
k8s-github-robot
added
release-note
enisoc
added
cherry-pick-approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
thockin
force-pushed
the
automated-cherry-pick-of-#44053-#44313-upstream-release-1.6
branch
from
20adb85
to
03102ec
Compare
k8s-github-robot
removed
the
lgtm
|
Sorry, the commits seem a bit weird to me...Why we have two federation commits in the middle? |
|
Need to clean those federation commits. This is generally caused by reverts in HEAD. |
The existing healthcheck lib was pretty complicated and was hiding some bugs (like the count always being 1), This is a reboot of the interface and implementation to be significantly simpler and better tested.
thockin
force-pushed
the
automated-cherry-pick-of-#44053-#44313-upstream-release-1.6
branch
from
03102ec
to
ef39e80
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: MrHohn, enisoc, thockin
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue |
|
Commit found in the "release-1.6" branch appears to be this PR. Removing the "cherrypick-candidate" label. If this is an error find help to get your PR picked. |
|
@thockin: The following test(s) failed:
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
k8s-github-robot
pushed a commit
that referenced
this pull request
Apr 18, 2017
Automatic merge from submit-queue Manual cherry pick of part of #44053 to release-1.5 This cherry pick has the same purpose as #44246 and #44315. The first commit is a manual application of git commit 7664b97 to release-1.5 branch. The unit test part is dropped as it has too many dependencies that shouldn't be cherry picked. The second commit is a surgical fix that does not exist on 1.6+, as we overhauled healthcheck package completely. It fixes the health check deletion logic in OnServiceUpdate for the same bug. @thockin @freehan **Release note**: ```release-note Fix for kube-proxy healthcheck handling an update that simultaneously removes one port and adds another. ```
mintzhao
pushed a commit
to mintzhao/kubernetes
that referenced
this pull request
Jun 1, 2017
…k-of-#44053-kubernetes#44313-upstream-release-1.6 Automatic merge from submit-queue Automated cherry pick of kubernetes#44053 kubernetes#44313 Cherry pick of kubernetes#44053 kubernetes#44313 on release-1.6. kubernetes#44053: Add tests for kube-proxy healthcheck, fix bug kubernetes#44313: Zero-out healthchecks when no endpoints ```release-note Fix corner-case with OnlyLocal Service healthchecks ```
thockin
deleted the
automated-cherry-pick-of-#44053-#44313-upstream-release-1.6
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #44053 #44313 on release-1.6.
#44053: Add tests for kube-proxy healthcheck, fix bug
#44313: Zero-out healthchecks when no endpoints