Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

failure-domain is no longer used in command line arg. #44386

Merged
merged 1 commit into from
Apr 14, 2017
Merged

failure-domain is no longer used in command line arg. #44386

merged 1 commit into from
Apr 14, 2017

Conversation

gyliu513
Copy link
Contributor

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

Release note:

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 12, 2017
@k8s-github-robot k8s-github-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. release-note-label-needed labels Apr 12, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@gyliu513
Copy link
Contributor Author

@k8s-bot unit test this

@ncdc
Copy link
Member

ncdc commented Apr 12, 2017

@wojtek-t this comment is safe to remove?

@gyliu513
Copy link
Contributor Author

failure-domain is deprecated in #41195 , and there are also some discussion here https://groups.google.com/forum/#!msg/kubernetes-sig-scheduling/P249hlfGcdw/_wfQ7UOlBQAJ @ncdc

@gyliu513
Copy link
Contributor Author

Related with kubernetes/website#3352

@gyliu513
Copy link
Contributor Author

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed labels Apr 13, 2017
@wojtek-t wojtek-t self-assigned this Apr 13, 2017
@wojtek-t
Copy link
Member

@ncdc - yes it is.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 13, 2017
@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gyliu513, wojtek-t

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 13, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 44424, 44026, 43939, 44386, 42914)

@k8s-github-robot k8s-github-robot merged commit f83badf into kubernetes:master Apr 14, 2017
@gyliu513 gyliu513 deleted the comment branch April 14, 2017 05:08
@gyliu513 gyliu513 mentioned this pull request Jun 6, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ncdc ncdc

@smarterclayton smarterclayton

@wojtek-t wojtek-t

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gyliu513 @k8s-reviewable @ncdc @wojtek-t @k8s-github-robot @smarterclayton @k8s-ci-robot