Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Garbage collector should support non-core APIs #44507

Closed
caesarxuchao opened this issue Apr 14, 2017 · 6 comments
Closed

Garbage collector should support non-core APIs #44507

caesarxuchao opened this issue Apr 14, 2017 · 6 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
CustomResourceDefinition

Comments

@caesarxuchao
Copy link
Member

Currently the garbage collector does not handle non-core APIs, like the APIs created via Thirdparty Resource or via the aggregated apiserver.

To support the non-core APIs, Garbage collector needs to:

  • dynamically adjust the resources it watches for (here)
  • use a dynamic RESTMapper when translating Kind to Resourse (here)
@caesarxuchao caesarxuchao added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 14, 2017
@caesarxuchao caesarxuchao mentioned this issue Apr 14, 2017
Closed
@0xmichalis 0xmichalis added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Apr 14, 2017
@r2d4 r2d4 mentioned this issue Apr 20, 2017
Closed
@lavalamp lavalamp added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 22, 2017
@ash2k ash2k mentioned this issue May 7, 2017
Closed
@lavalamp lavalamp assigned lavalamp and unassigned caesarxuchao May 17, 2017
@lavalamp lavalamp mentioned this issue May 17, 2017
Closed
@krmayankk
Copy link

@caesarxuchao is this the issue tracking garbage collection for TPR ?

@ngtuna ngtuna mentioned this issue Jun 4, 2017
Closed
@ngtuna
Copy link
Contributor

ngtuna commented Jun 4, 2017

Same question with @krmayankk This would be really helpful if GC can support TPR :-)

@nikhita
Copy link
Member

nikhita commented Jun 4, 2017

There is a PR (in progress) with a fix here: #46000.

@ngtuna
Copy link
Contributor

ngtuna commented Jun 4, 2017

Thanks @nikhita

@liggitt liggitt mentioned this issue Jun 16, 2017
Closed
@ironcladlou ironcladlou mentioned this issue Jun 16, 2017
Merged
@lavalamp lavalamp removed their assignment Jun 22, 2017
@caesarxuchao
Copy link
Member Author

#47665 is addressing the issue.

@enisoc enisoc added this to Backlog in CustomResourceDefinition Jul 13, 2017
@ironcladlou ironcladlou mentioned this issue Jul 27, 2017
Closed
k8s-github-robot pushed a commit that referenced this issue Jul 29, 2017
Merge pull request #47665 from ironcladlou/gc-poll-types
7be28a1 
Automatic merge from submit-queue (batch tested with PRs 49538, 49708, 47665, 49750, 49528)

Enable garbage collection of custom resources

Enhance the garbage collector to periodically refresh the resources it monitors (via discovery) to enable custom resource definition GC (addressing #44507 and reverting #47432).

This is a replacement for #46000.

/cc @lavalamp @deads2k @sttts @caesarxuchao 

/ref #48065

```release-note
The garbage collector now supports custom APIs added via CustomeResourceDefinition or aggregated apiservers. Note that the garbage collector controller refreshes periodically, so there is a latency between when the API is added and when the garbage collector starts to manage it.
```
@lavalamp
Copy link
Member

Looks like @ironcladlou finished off what I started and this is done. Thanks!!

@jlewi jlewi mentioned this issue Sep 26, 2017
Closed
@enisoc enisoc moved this from Backlog to Done in CustomResourceDefinition Sep 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery.
Projects
No open projects
CustomResourceDefinition
Done
Milestone
No milestone
Development

No branches or pull requests
6 participants
@lavalamp @ngtuna @caesarxuchao @0xmichalis @nikhita @krmayankk