Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up edit and refactor edit #44905

Closed
mengqiy opened this issue Apr 25, 2017 · 3 comments
Closed

Clean up edit and refactor edit #44905

mengqiy opened this issue Apr 25, 2017 · 3 comments
Assignees
@shiywang

Comments

@mengqiy
Copy link
Member

mengqiy commented Apr 25, 2017

Fix comments left in #39404.
Make other necessary refactor changes to edit to make it easier for edit last-applied.
@mengqiy
Copy link
Member Author

mengqiy commented Apr 25, 2017

/assign @shiywang

@mengqiy mengqiy mentioned this issue Apr 25, 2017
Merged
@mengqiy mengqiy mentioned this issue May 6, 2017
Merged
@0xmichalis
Copy link
Contributor

We can proceed with this now that edit has been made re-usable.

@0xmichalis
Copy link
Contributor

Oh well, I was thinking of a different issue #38761 - this is done.

enisoc pushed a commit to enisoc/kubernetes that referenced this issue May 26, 2017
Merge pull request kubernetes#42256 from shiywang/edit
f3406bf 
Automatic merge from submit-queue (batch tested with PRs 42256, 46479, 45436, 46440, 46417)

Add `kubectl apply edit-last-applied` subcommand

third command of kubernetes/community#287
Fixes kubernetes#44905
@pwittrock @adohe @ymqytw @kubernetes/sig-cli-feature-requests could you guys have an early review ? cause some of feature I'm not sure about, will add unit tests if you think it's ok.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shiywang shiywang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mengqiy @0xmichalis @shiywang