Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace CloneTLSConfig() with (*tls.Config).Clone() #44961

Merged
merged 1 commit into from
Apr 28, 2017
Merged

replace CloneTLSConfig() with (*tls.Config).Clone() #44961

merged 1 commit into from
Apr 28, 2017

Conversation

mikedanese
Copy link
Member

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 26, 2017
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-github-robot k8s-github-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. release-note-label-needed labels Apr 26, 2017
@mikedanese mikedanese mentioned this pull request Apr 26, 2017
Closed
@smarterclayton
Copy link
Contributor

/approve

@k8s-github-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mikedanese, smarterclayton

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-github-robot k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 26, 2017
@smarterclayton
Copy link
Contributor

Change LGTM, self merge when green

@mikedanese
Copy link
Member Author

@k8s-bot unit test this
@k8s-bot node e2e test this
@k8s-bot verify test this

@mikedanese mikedanese added lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. and removed release-note-label-needed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Apr 28, 2017
@mikedanese
Copy link
Member Author

@k8s-bot unit test this

@mikedanese mikedanese added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 28, 2017
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 45033, 44961, 45021, 45097, 44938)

@k8s-github-robot k8s-github-robot merged commit 90d5fbc into kubernetes:master Apr 28, 2017
@mikedanese mikedanese deleted the fix-clone branch April 28, 2017 20:17
@CaoShuFeng
Copy link
Contributor

CaoShuFeng commented May 2, 2017 •
edited

I known we are moving to go 1.8.
After this, go 1.7 can't compile kubernetes, do we need to document that kubernetes 1.7 doesn't support go 1.7 anymore?
Thanks

@wojtek-t wojtek-t mentioned this pull request May 8, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@smarterclayton smarterclayton

@dchen1107 dchen1107

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mikedanese @k8s-reviewable @smarterclayton @k8s-github-robot @CaoShuFeng @dchen1107 @k8s-ci-robot