initial types for TPRs #45115

deads2k · 2017-04-28T18:33:50Z

This pull starts creating the types described by https://github.com/kubernetes/community/blob/master/contributors/design-proposals/thirdpartyresources.md . In the initial pull different names were suggested. I've started this pull with CustomResource.apiextensions.k8s.io.

The structure begins as a separate API server to facilitate rapid prototyping and experimentation, but the end result will be added to the end of the kube-apiserver chain as described in https://github.com/kubernetes/community/blob/master/sig-api-machinery/api-extensions-position-statement.md .

Because it is separate to start (not included in any default server), I don't think we need a perfect name, but I'd like to be close.

@kubernetes/sig-api-machinery-misc @enisoc @smarterclayton @erictune

k8s-reviewable · 2017-04-28T18:33:57Z

This change is

k8s-github-robot · 2017-04-28T18:40:47Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: deads2k
We suggest the following additional approver: smarterclayton

Assign the PR to them by writing /assign @smarterclayton in a comment when ready.

Needs approval from an approver in each of these OWNERS Files:

OWNERS

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

sttts · 2017-05-02T07:38:49Z

staging/src/k8s.io/kube-apiextensions-server/pkg/apis/apiextensions/types.go

+
+// CustomResourceNames indicates the names to serve this CustomResource
+type CustomResourceNames struct {
+	// Plural is the plural name of the resource to serve.  It must match the name of the TPR-registration


Would also mention "lower-case" here.

sttts · 2017-05-02T07:43:19Z

staging/src/k8s.io/kube-apiextensions-server/pkg/apiserver/apiserver.go

@@ -0,0 +1,116 @@
+/*
+Copyright 2016 The Kubernetes Authors.


sttts · 2017-05-02T08:04:23Z

staging/src/k8s.io/kube-apiextensions-server/pkg/apis/apiextensions/types.go

+
+import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+
+// CustomResourceSpec describe how a user wants their resource to appear


nit: describes

sttts · 2017-05-02T08:05:44Z

staging/src/k8s.io/kube-apiextensions-server/pkg/apis/apiextensions/types.go

+	Conditions []CustomResourceCondition
+
+	// AcceptedNames are the names that are actually being used to serve discovery
+	// They may be different than the names in spec.


different = a subset?

Forseeing clients which do complicated comparison logic whether everything specified is actually accepted. Can we at least express this with a boolean Accepted: Partially/Complete ?

different = a subset?

No, different. Imagine someone changing their shortnames. The status may have values not present in the spec.

Can we at least express this with a boolean Accepted: Partially/Complete ?

It would set the nameconflict condition.

deads2k · 2017-05-02T13:20:50Z

@k8s-bot unit test this: issue #45170

sttts · 2017-05-02T14:22:44Z

Looks good from my side as a first step. As nothing is exposed yet, we can freely change types and names in a follow-up if necessary.

deads2k · 2017-05-02T15:25:01Z

@k8s-bot verify test this

deads2k · 2017-05-02T19:44:09Z

Looks good from my side as a first step. As nothing is exposed yet, we can freely change types and names in a follow-up if necessary.

@ericchiang Anything to add at the moment? I'm flexible on names both now and later.

ericchiang

Types work for me. One question about the API group name.

ericchiang · 2017-05-02T20:03:39Z

staging/src/k8s.io/kube-apiextensions-server/pkg/apis/apiextensions/v1alpha1/types.go

+limitations under the License.
+*/
+
+package v1alpha1


Hm, I had assumed this would be a beta group based on the proposal.

Hm, I had assumed this would be a beta group based on the proposal.

I really want to make it to beta, but I don't want to rush it and later regret it. If we decide this API is actually good enough to be beta, I'm fine with simply switching it later this release or adding a congruent file next release.

deads2k · 2017-05-03T11:45:33Z

Looks like there's enough consensus to move forward with a non-exposed API like this. I am flexible about changing these names and I've opened #45277 to make sure that's well known.

I'm going to tag this so we can get a critical mass available for dealing with the issues around actually making it work and playing with migration cases.

k8s-github-robot · 2017-05-03T12:36:58Z

Automatic merge from submit-queue (batch tested with PRs 45272, 45115)

@enisoc

Automatic merge from submit-queue (batch tested with PRs 45182, 45429) CustomResources in separate API server Builds on #45115. This adds a basic handler for custom resources. No status handling, no finalizers, no controllers, but basic CRUD runs to allow @enisoc and others to start considering migration. @kubernetes/sig-api-machinery-misc

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 28, 2017

deads2k assigned smarterclayton, enisoc and erictune Apr 28, 2017

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels Apr 28, 2017

deads2k mentioned this pull request May 1, 2017

Proposal: TPR to beta proposal kubernetes/community#524

Merged

deads2k force-pushed the tpr-07-types branch 2 times, most recently from dbb608a to 9d6b5a2 Compare May 1, 2017 19:53

deads2k mentioned this pull request May 1, 2017

CustomResources in separate API server #45182

Merged

sttts reviewed May 2, 2017

View reviewed changes

deads2k added 5 commits May 2, 2017 08:43

wire new staging repo

ed27887

types

a0b6241

generated

72eef13

create apiserver for extensions

c7e68a2

image and resources for manual testing

6a74988

deads2k force-pushed the tpr-07-types branch from 9d6b5a2 to 6a74988 Compare May 2, 2017 12:49

ericchiang reviewed May 2, 2017

View reviewed changes

deads2k mentioned this pull request May 3, 2017

Reassess names, fields, and groups for CustomResources #45277

Closed

deads2k added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 3, 2017

deads2k added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed release-note-label-needed labels May 3, 2017

k8s-github-robot added release-note-label-needed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. labels May 3, 2017

deads2k added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge DEPRECATED. Indicates that a PR should not merge. Label can only be manually applied/removed. release-note-label-needed labels May 3, 2017

k8s-github-robot merged commit df8551a into kubernetes:master May 3, 2017

deads2k mentioned this pull request Jun 6, 2017

mungegithub: publish apiextensions-apiserver kubernetes/test-infra#2978

Merged

deads2k deleted the tpr-07-types branch August 3, 2017 20:08

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

initial types for TPRs #45115

initial types for TPRs #45115

deads2k commented Apr 28, 2017

k8s-reviewable commented Apr 28, 2017

k8s-github-robot commented Apr 28, 2017

sttts May 2, 2017

sttts May 2, 2017

sttts May 2, 2017

sttts May 2, 2017

sttts May 2, 2017

deads2k May 2, 2017

deads2k May 2, 2017

deads2k commented May 2, 2017

sttts commented May 2, 2017

deads2k commented May 2, 2017

deads2k commented May 2, 2017

ericchiang left a comment •

edited

ericchiang May 2, 2017

deads2k May 3, 2017

deads2k commented May 3, 2017

k8s-github-robot commented May 3, 2017


		import metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"

		// CustomResourceSpec describe how a user wants their resource to appear

initial types for TPRs #45115

initial types for TPRs #45115

Conversation

deads2k commented Apr 28, 2017

k8s-reviewable commented Apr 28, 2017

k8s-github-robot commented Apr 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deads2k commented May 2, 2017

sttts commented May 2, 2017

deads2k commented May 2, 2017

deads2k commented May 2, 2017

ericchiang left a comment • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

deads2k commented May 3, 2017

k8s-github-robot commented May 3, 2017

ericchiang left a comment •

edited