-
Notifications
You must be signed in to change notification settings - Fork 38.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use groupName comment for listers/informers #45171
Conversation
If present, use the "// +groupName" doc comment as the desired group name when generating listers and informers.
/lgtm |
@k8s-bot gce etcd3 e2e test this Various namespaces failed to delete in time. Will see if I can root cause that. |
/lgtm |
@smarterclayton or @lavalamp, care to approve? |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, ncdc, smarterclayton, sttts
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
@k8s-bot ok to test |
@k8s-bot gce etcd3 e2e test this |
Automatic merge from submit-queue |
If present, use the "// +groupName" doc comment as the desired group
name when generating listers and informers.
@kubernetes/sig-api-machinery-pr-reviews @smarterclayton @deads2k @liggitt @sttts