Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

StatefulSet tests need to be updated for 1.6 annotations #45202

Closed
justinsb opened this issue May 2, 2017 · 2 comments
Closed

StatefulSet tests need to be updated for 1.6 annotations #45202

justinsb opened this issue May 2, 2017 · 2 comments
Labels
area/stateful-apps area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Milestone
v1.7

Comments

@justinsb
Copy link
Member

justinsb commented May 2, 2017

e.g. https://github.com/kubernetes/kubernetes/blob/master/test/e2e/testing-manifests/statefulset/zookeeper/statefulset.yaml#L13

As @kow3ns pointed out here #41180 (comment):

If you are targeting >= 1.6 you should be using the fields instead of the annotations.
@justinsb justinsb mentioned this issue May 2, 2017
Closed
@0xmichalis 0xmichalis added area/stateful-apps area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. labels May 2, 2017
@0xmichalis
Copy link
Contributor

@kubernetes/sig-apps-misc

@grodrigues3 grodrigues3 added this to the v1.7 milestone May 4, 2017
@enisoc
Copy link
Member

enisoc commented Jun 9, 2017

This appears to have been duped by #45405 and fixed by #45447.

@enisoc enisoc closed this as completed Jun 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/stateful-apps area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps.
Projects
None yet
Milestone
v1.7
Development

No branches or pull requests
4 participants
@justinsb @0xmichalis @grodrigues3 @enisoc