Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Put init-containers to PodSpec #45405

Closed
gyliu513 opened this issue May 5, 2017 · 2 comments · Fixed by #45447
Closed

Put init-containers to PodSpec #45405

gyliu513 opened this issue May 5, 2017 · 2 comments · Fixed by #45447
Assignees
@gyliu513

Comments

@gyliu513
Copy link
Contributor

gyliu513 commented May 5, 2017 •
edited

Is this a request for help? (If yes, you should use our troubleshooting guide and community support channels, see http://kubernetes.io/docs/troubleshooting/.):

What keywords did you search in Kubernetes issues before filing this one? (If you have found any duplicates, you should instead reply there.):

Is this a BUG REPORT or FEATURE REQUEST? (choose one):

Kubernetes version (use kubectl version):
HEAD

Environment:

  • Cloud provider or hardware configuration:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

What happened:
The init container is graduated to GA , so some test YAML templates needs to be updated to not use annotations.

The following are the two places that needs update:

  1. cockroachdb
  2. e2e statefulset test

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:
@gyliu513
Copy link
Contributor Author

gyliu513 commented May 5, 2017

/assign

@gyliu513
Copy link
Contributor Author

gyliu513 commented May 5, 2017

related to #45318

@gyliu513 gyliu513 mentioned this issue May 6, 2017
Merged
k8s-github-robot pushed a commit that referenced this issue May 6, 2017
Merge pull request #45447 from gyliu513/init-container
dfc04ab 
Automatic merge from submit-queue

Put initContainers to PodSpec for some statefulset examples.

**What this PR does / why we need it**:
Fixed #45405

The `init container` is [graduated to GA](#38382) , so some test YAML templates needs to be updated to not use `annotations`.

The following are the two places that needs update:
1. [cockroachdb](https://github.com/kubernetes/kubernetes/blob/master/examples/cockroachdb/cockroachdb-statefulset.yaml)
2. [e2e statefulset test](https://github.com/kubernetes/kubernetes/tree/master/test/e2e/testing-manifests/statefulset)

**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #

**Special notes for your reviewer**:

**Release note**:

```release-note
```
@enisoc enisoc mentioned this issue Jun 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gyliu513 gyliu513

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Put initContainers to PodSpec for some statefulset examples. gyliu513/kubernetes
1 participant
@gyliu513