Apiregistration v1alpha1→v1beta1 #45247

mbohlool · 2017-05-02T22:14:25Z

Promoting apiregistration api from v1alpha1 to v1beta1.

API Registration is responsible for registering an API Group/Version with
another kubernetes like API server. The APIService holds information
about the other API server in APIServiceSpec type as well as general
TypeMeta and ObjectMeta. The APIServiceSpec type have the main
configuration needed to do the aggregation. Any request coming for
specified Group/Version will be directed to the service defined by
ServiceReference (on port 443) after validating the target using provided
CABundle or skipping validation if development flag InsecureSkipTLSVerify
is set. Priority is controlling the order of this API group in the overall
discovery document.
The return status is a set of conditions for this aggregation. Currently
there is only one condition named "Available", if true, it means the
api/server requests will be redirected to specified API server.

API Registration is now in beta.

k8s-reviewable · 2017-05-02T22:14:32Z

This change is

lavalamp

No changes to the types themselves?

lavalamp · 2017-05-08T21:55:05Z

staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1/doc.go

+// +k8s:deepcopy-gen=package,register
+// +k8s:conversion-gen=k8s.io/kubernetes/vendor/k8s.io/kube-aggregator/pkg/apis/apiregistration
+
+// API Registration is responsible for registering an API `Group`/`Version` with


"Package v1beta1 contains the API Registration API, which is..."

lavalamp · 2017-05-08T21:55:54Z

staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1/doc.go

+
+// API Registration is responsible for registering an API `Group`/`Version` with
+// another kubernetes like API server. The `APIService` holds information
+// about the other API server in `APIServiceSpec` type as well as general


Suggest explaining the types in comments on the types instead of in the package comment?

I was thinking a general idea of what these APIs are doing is helpful. I think I can sell this instead of one pager Brian asked for, what do you think?

lavalamp · 2017-05-08T22:02:30Z

cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go

@@ -68,7 +68,7 @@ func New() *Generator {
 			`+k8s.io/apimachinery/pkg/runtime`,
 			`k8s.io/apimachinery/pkg/apis/meta/v1`,
 			`k8s.io/apiserver/pkg/apis/example/v1`,
-			`k8s.io/kube-aggregator/pkg/apis/apiregistration/v1alpha1`,
+			`k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1`,


not a thing to change in this PR but I think mixing api group sources in the client generator default list like this is a bad precedent.

mbohlool

Correct. No change to API types themselves. I looked at them and they look fine to me. Any suggestion?

mbohlool · 2017-05-09T19:42:35Z

staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1/doc.go

+
+// API Registration is responsible for registering an API `Group`/`Version` with
+// another kubernetes like API server. The `APIService` holds information
+// about the other API server in `APIServiceSpec` type as well as general


I was thinking a general idea of what these APIs are doing is helpful. I think I can sell this instead of one pager Brian asked for, what do you think?

mbohlool · 2017-05-09T19:42:45Z

cmd/libs/go2idl/go-to-protobuf/protobuf/cmd.go

@@ -68,7 +68,7 @@ func New() *Generator {
 			`+k8s.io/apimachinery/pkg/runtime`,
 			`k8s.io/apimachinery/pkg/apis/meta/v1`,
 			`k8s.io/apiserver/pkg/apis/example/v1`,
-			`k8s.io/kube-aggregator/pkg/apis/apiregistration/v1alpha1`,
+			`k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1`,


mbohlool · 2017-05-09T19:47:26Z

staging/src/k8s.io/kube-aggregator/pkg/apis/apiregistration/v1beta1/doc.go

+// +k8s:deepcopy-gen=package,register
+// +k8s:conversion-gen=k8s.io/kubernetes/vendor/k8s.io/kube-aggregator/pkg/apis/apiregistration
+
+// API Registration is responsible for registering an API `Group`/`Version` with


lavalamp · 2017-05-12T23:32:59Z

@smarterclayton do you know why the proto thing changed all the binary blobs? I have seen this in a few places now.

@deads2k any objections to making this API beta?

lavalamp · 2017-05-12T23:33:55Z

This will break the sample apiserver config, I guess. We can fix it up once this merges. (fyi @cheftako )

deads2k · 2017-05-15T11:58:14Z

@deads2k any objections to making this API beta?

Sounds good to me.

smarterclayton · 2017-05-15T21:05:51Z

Proto change was because protobuf tar/gzs up the .proto into the generated.pb.go file (and I can't figure out how to disable it without invasive changes). Whenever anything in there changes, or if the Go version changes how gzip works, the contents change.

smarterclayton · 2017-05-15T21:07:02Z

LGTM, @deads2k any other comments?

mbohlool · 2017-05-16T00:42:06Z

@k8s-bot pull-kubernetes-federation-e2e-gce test this

deads2k · 2017-05-16T13:04:05Z

/lgtm

lavalamp · 2017-05-17T00:20:59Z

/approve

k8s-github-robot · 2017-05-17T00:21:11Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, lavalamp, mbohlool

Needs approval from an approver in each of these OWNERS Files:

~~cmd/kube-apiserver/OWNERS~~ [deads2k,lavalamp]
~~cmd/libs/go2idl/go-to-protobuf/OWNERS~~ [lavalamp]
~~federation/OWNERS~~ [lavalamp]
~~hack/OWNERS~~ [deads2k,lavalamp]
~~pkg/api/OWNERS~~ [lavalamp]
~~pkg/controller/OWNERS~~ [deads2k,lavalamp]
~~staging/src/k8s.io/client-go/OWNERS~~ [deads2k,lavalamp]
~~staging/src/k8s.io/kube-aggregator/OWNERS~~ [deads2k,lavalamp]
~~staging/src/k8s.io/sample-apiserver/OWNERS~~ [deads2k,lavalamp]
~~test/OWNERS~~ [deads2k,lavalamp]

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

k8s-github-robot · 2017-05-17T02:01:55Z

Automatic merge from submit-queue (batch tested with PRs 45247, 45810, 45034, 45898, 45899)

mbohlool self-assigned this May 2, 2017

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 2, 2017

k8s-github-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. release-note-label-needed labels May 2, 2017

mbohlool force-pushed the c3 branch 3 times, most recently from 4cb46a4 to 0a0d1c4 Compare May 3, 2017 01:09

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2017

mbohlool force-pushed the c3 branch from 0a0d1c4 to cf98dc1 Compare May 3, 2017 17:44

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2017

mbohlool assigned lavalamp and unassigned mbohlool May 3, 2017

mbohlool requested a review from lavalamp May 3, 2017 17:45

mbohlool changed the title ~~[WIP] Apiregistration alpha1->beta2~~ Apiregistration alpha1->beta2 May 3, 2017

k8s-github-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-label-needed labels May 3, 2017

mbohlool changed the title ~~Apiregistration alpha1->beta2~~ Apiregistration alpha1->beta1 May 3, 2017

mbohlool changed the title ~~Apiregistration alpha1->beta1~~ Apiregistration alpha1→beta1 May 3, 2017

mbohlool changed the title ~~Apiregistration alpha1→beta1~~ Apiregistration v1alpha1→v1beta1 May 3, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 4, 2017

lavalamp reviewed May 8, 2017

View reviewed changes

mbohlool commented May 9, 2017

View reviewed changes

mbohlool force-pushed the c3 branch from 19ab3b1 to 54fb3a6 Compare May 11, 2017 23:00

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 11, 2017

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 12, 2017

smarterclayton self-assigned this May 15, 2017

mbohlool force-pushed the c3 branch from 54fb3a6 to 662ebab Compare May 15, 2017 18:45

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 15, 2017

mbohlool added 2 commits May 15, 2017 15:34

Promote apiregistration from v1alpha1 to v1beta1

e2f20a3

Update generated files

103c1bf

mbohlool force-pushed the c3 branch from 662ebab to 103c1bf Compare May 15, 2017 23:28

k8s-ci-robot assigned deads2k May 16, 2017

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 16, 2017

k8s-github-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2017

k8s-github-robot merged commit 3f0ebbe into kubernetes:master May 17, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Apiregistration v1alpha1→v1beta1 #45247

Apiregistration v1alpha1→v1beta1 #45247

mbohlool commented May 2, 2017 •

edited

k8s-reviewable commented May 2, 2017

lavalamp left a comment

lavalamp May 8, 2017

mbohlool May 9, 2017

lavalamp May 8, 2017

mbohlool May 9, 2017

lavalamp May 8, 2017

mbohlool May 9, 2017

mbohlool left a comment

mbohlool May 9, 2017

mbohlool May 9, 2017

mbohlool May 9, 2017

lavalamp commented May 12, 2017

lavalamp commented May 12, 2017

deads2k commented May 15, 2017

smarterclayton commented May 15, 2017

smarterclayton commented May 15, 2017

mbohlool commented May 16, 2017

deads2k commented May 16, 2017

lavalamp commented May 17, 2017

k8s-github-robot commented May 17, 2017

k8s-github-robot commented May 17, 2017

Apiregistration v1alpha1→v1beta1 #45247

Apiregistration v1alpha1→v1beta1 #45247

Conversation

mbohlool commented May 2, 2017 • edited

k8s-reviewable commented May 2, 2017

lavalamp left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbohlool left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lavalamp commented May 12, 2017

lavalamp commented May 12, 2017

deads2k commented May 15, 2017

smarterclayton commented May 15, 2017

smarterclayton commented May 15, 2017

mbohlool commented May 16, 2017

deads2k commented May 16, 2017

lavalamp commented May 17, 2017

k8s-github-robot commented May 17, 2017

k8s-github-robot commented May 17, 2017

mbohlool commented May 2, 2017 •

edited