Rename //:ci-artifacts rule to //:push-build, and add a deprecated alias #45250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-github-robot
added
size/XS
|
This change is |
mikedanese
reviewed
May 2, 2017
BUILD.bazel
Outdated
| @@ -33,6 +33,12 @@ gcs_upload( | |||
| }, | |||
| ) | |||
|
|
|||
| alias( | |||
| name = "ci-artifacts", | |||
There was a problem hiding this comment.
Please add "Deprecated TODO: remove" comment.
There was a problem hiding this comment.
added a TODO and a date for removal (~3 weeks), i.e. before 1.7 freeze.
ixdy
force-pushed
the
bazel-push-build-alias
branch
from
78d1644
to
4c51d1e
Compare
|
/approve |
k8s-github-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ixdy, spxtr, thockin
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
|
Automatic merge from submit-queue (batch tested with PRs 45314, 45250, 41733) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: this rule has a larger scope than just CI artifacts now, so it seems like the name should be updated to match. WDYT?
This is a separate PR to facilitate easy cherry-picking; I'd rather test-infra jobs not need to special-case.
/assign @spxtr @mikedanese
Release note: